2013-04-16 Lucas Forschler Merge r148483 2013-04-15 Anders Carlsson plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=114653 Reviewed by Sam Weinig. Protect the NetscapePluginInstanceProxy since it can otherwise go away. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest): 2013-01-30 Lucas Forschler Merge r138606 2013-01-01 Dan Bernstein Update copyright strings Reviewed by Sam Weinig. * Info.plist: 2012-11-27 Lucas Forschler Merge r133702 2012-11-06 Anders Carlsson Update Java related WKSI function names https://bugs.webkit.org/show_bug.cgi?id=101414 Reviewed by Sam Weinig. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::unavailablePluginButtonClicked): * WebCoreSupport/WebFrameLoaderClient.mm: (isPlugInInactive): 2012-11-27 Lucas Forschler Merge r133371 2012-11-02 Anders Carlsson Don't instantiate the Java plug-in if it's inactive https://bugs.webkit.org/show_bug.cgi?id=101102 Reviewed by Andreas Kling. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): The RenderEmbeddedObject::PluginInactive reason should always result in a button being shown. (WebChromeClient::unavailablePluginButtonClicked): If the Java plug-in is inactive, call WKJLReportWebComponentsUsed() to reactivate the plug-in and then reload the page. * WebCoreSupport/WebFrameLoaderClient.mm: (isOracleJavaPlugIn): (isPlugInInactive): Helper functions. (WebFrameLoaderClient::createPlugin): If the plug-in is inactive, set the appropriate unavailability reason on the renderer. 2012-11-16 Lucas Forschler Merge r131280 2012-10-14 Jon Lee Allow notification origin permission request when no js callback is provided https://bugs.webkit.org/show_bug.cgi?id=63615 Reviewed by Sam Weinig. Introduce a boolean to determine whether the request was using the legacy or standard API. This way, we do not fall through to calling the standard API's callback if the legacy API's callback is null. * WebCoreSupport/WebNotificationClient.mm: (WebCore): (-[WebNotificationPolicyListener initWithVoidCallback:]): (-[WebNotificationPolicyListener allow]): (-[WebNotificationPolicyListener deny]): 2012-11-16 Lucas Forschler Merge r130565 2012-10-05 Tim Horton [cg] GraphicsContextCG should ask CG whether the shadow offset workaround is required https://bugs.webkit.org/show_bug.cgi?id=98565 Reviewed by Simon Fraser. Add wkCGContextDrawsWithCorrectShadowOffsets. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-11-15 Lucas Forschler Merge r133977 2012-11-08 Roger Fong Null check URL key entries into WebHistory hash table. https://bugs.webkit.org/show_bug.cgi?id=101664 Reviewed by Brady Eidson. Sometimes the _entriesByURL hash table used to keep track of web history is erroneously passed in null key entries, which causes an exception to fire. This prevents the desired page navigation from taking effect. This is a workaround for the problem. Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown so that navigation can continue as expected. * History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]): 2012-11-12 Lucas Forschler Merge r131018 2012-10-10 Jer Noble Disallow full screen mode keyboard access by default. https://bugs.webkit.org/show_bug.cgi?id=98971 Reviewed by Sam Weinig. Only support full screen if keyboard access is not requested. * WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): 2012-08-06 Lucas Forschler Merge 123907 2012-07-27 Anders Carlsson Show the unavailable plug-in indicator for Java applets as well https://bugs.webkit.org/show_bug.cgi?id=92521 Reviewed by Sam Weinig. Check if the Java plug-in is blocked before trying to instantiate it. * WebCoreSupport/WebFrameLoaderClient.mm: 2012-08-06 Lucas Forschler Merge 123775 2012-07-25 Jer Noble Add setting to enable and disable diagnostic logging. https://bugs.webkit.org/show_bug.cgi?id=92337 Reviewed by Anders Carlsson. Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Register the default value to false. (-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor. (-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings whenever the preferences change. 2012-07-30 Lucas Forschler Merge 121646 2012-07-01 Timothy Hatcher Make the "Inspect Element" context menu item appear in nightly builds again. rdar://problem/11702613 https://webkit.org/b/89323 Reviewed by Dan Bernstein. * WebView/WebUIDelegatePrivate.h: Add missing enums that were added in ContextMenuItem.h but left out here. 2012-06-12 Lucas Forschler Merge 120357 2012-06-14 Jia Pu Mark text with text alternative with blue underline. https://bugs.webkit.org/show_bug.cgi?id=83047 Reviewed by Enrica Casucci. Changes in WebKit include implementation of new functions declared in AlternativeTextClient, and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's alternatives attached to the input string. * WebCoreSupport/CorrectionPanel.mm: (correctionIndicatorType): (CorrectionPanel::handleAcceptedReplacement): * WebCoreSupport/WebAlternativeTextClient.h: (WebAlternativeTextClient): * WebCoreSupport/WebAlternativeTextClient.mm: (WebAlternativeTextClient::showCorrectionAlternative): (WebAlternativeTextClient::dismissAlternative): (WebAlternativeTextClient::dismissAlternativeSoon): (WebAlternativeTextClient::recordAutocorrectionResponse): (WebAlternativeTextClient::removeDictationAlternatives): (WebAlternativeTextClient::showDictationAlternativeUI): (WebAlternativeTextClient::dismissDictationAlternativeUI): (WebAlternativeTextClient::dictationAlternatives): * WebView/WebHTMLView.mm: (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView insertText:]): * WebView/WebView.mm: (-[WebView handleAcceptedAlternativeText:]): (-[WebView _getWebCoreDictationAlternatives:fromTextAlternatives:]): (-[WebView _showDictationAlternativeUI:WebCore::forDictationContext:]): (-[WebView _dismissDictationAlternativeUI]): (-[WebView _removeDictationAlternatives:]): (-[WebView _dictationAlternatives:]): * WebView/WebViewData.h: * WebView/WebViewData.mm: (-[WebViewPrivate init]): * WebView/WebViewInternal.h: * WebView/WebViewPrivate.h: 2012-06-12 Lucas Forschler Merge 119280 2012-06-01 Michael Saboff WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string https://bugs.webkit.org/show_bug.cgi?id=88109 Reviewed by Geoffrey Garen. Added short circuit return when the NSString to evaluate is nil. * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 2012-06-12 Lucas Forschler Merge 119543 2012-06-05 Anders Carlsson Build fix. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): The error constant has been renamed. 2012-06-12 Lucas Forschler Merge 119542 2012-06-05 Anders Carlsson Rename a plug-in loading error constant https://bugs.webkit.org/show_bug.cgi?id=88381 Reviewed by Sam Weinig. * Misc/WebKitErrors.h: 2012-06-06 Mark Rowe Merge r119339. 2012-06-02 Yongjun Zhang loadRequest should check for empty URLs. https://bugs.webkit.org/show_bug.cgi?id=88154 In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url. However, WebKit client could send down an empty URL that makes us transform it to file: url as well. We should skip that as we did for nil URLs. Reviewed by Brady Eidson. * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): 2012-05-31 Ojan Vafai add back the ability to disable flexbox https://bugs.webkit.org/show_bug.cgi?id=87147 Reviewed by Tony Chang. * Configurations/FeatureDefines.xcconfig: 2012-05-31 Tim Horton Disable CSS3 flexbox Reviewed by John Sullivan. * Configurations/FeatureDefines.xcconfig: 2012-05-31 Tim Horton Add feature defines for web-facing parts of CSS Regions and Exclusions https://bugs.webkit.org/show_bug.cgi?id=87442 Reviewed by Dan Bernstein. * Configurations/FeatureDefines.xcconfig: 2012-05-24 Lucas Forschler Merge 118086 2012-05-22 Tim Horton Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad https://bugs.webkit.org/show_bug.cgi?id=87178 Reviewed by Maciej Stachowiak. Add plumbing for the quirk to flip the relative ordering of progressCompleted/didFinishLoad back to the behavior before http://trac.webkit.org/changeset/94105. Make it apply to any Mail.app linked against WebKit before that revision. * Misc/WebKitVersionChecks.h: * WebView/WebView.mm: (-[WebView _needsDidFinishLoadOrderQuirk]): (-[WebView _preferencesChanged:]): 2012-05-21 Lucas Forschler Merge 117510 2012-05-17 Andy Estes Don't let -[CALayer renderInContext:] try to render WebView's root layer https://bugs.webkit.org/show_bug.cgi?id=86773 Reviewed by Dan Bernstein. -[CALayer renderInContext:] doesn't correctly render our layer tree, so don't let it try. Calling drawRect: with a bitmap context will already do the right thing for WebViews. * WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer. (-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP. (-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer. 2012-05-16 Lucas Forschler Merge 117129 2012-05-15 Anders Carlsson Use unaccelerated scrolling deltas when rubber-banding https://bugs.webkit.org/show_bug.cgi?id=86503 Reviewed by Sam Weinig. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Init new WKSI functions. 2012-05-15 Sam Weinig ENABLE_IFRAME_SEAMLESS should be turned off on the branch Reviewed by Andy Estes. * Configurations/FeatureDefines.xcconfig: Disable ENABLE_IFRAME_SEAMLESS. 2012-05-15 Sam Weinig Disable CSS regions Reviewed by Anders Carlsson. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Disable regions by default 2012-05-15 Lucas Forschler Merge 116820 2012-05-11 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=86265 REGRESSION(r104885): Images missing from printed YummySoup! recipes We thought clients were passing paths as URLs. It turns out it was more likely they were passing file: URLs with the file: scheme removed. And that jives perfectly with the behavior change caused by r104885. Reviewed by Alexey Proskuryakov. Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it to create the new URL simply by appending "file:": * Misc/WebNSURLExtras.h: * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrSchemelessFileURL]): * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the existing URL string. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): (-[WebFrame loadHTMLString:baseURL:]): (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): 2012-05-15 Lucas Forschler Merge 116695 2012-05-10 Anders Carlsson WebKit1: Add a way to blacklist specific plug-ins/plug-in versions https://bugs.webkit.org/show_bug.cgi?id=86150 Reviewed by Sam Weinig. * Misc/WebKitErrors.h: Add WebKitErrorInsecurePlugInVersion enum. * Plugins/WebBasePluginPackage.h: * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage bundleIdentifier]): (-[WebBasePluginPackage bundleVersion]): Add bundleIdentifier and bundleVersion getters. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check if the plug-in is blocked. If it is, set the unavailability reason and the error code. 2012-05-15 Lucas Forschler Merge 116687 2012-05-10 Anders Carlsson Rename the missing plug-in indicator to the unavailable plug-in indicator https://bugs.webkit.org/show_bug.cgi?id=86136 Reviewed by Sam Weinig. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]): * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldUnavailablePluginMessageBeButton): (WebChromeClient::unavailablePluginButtonClicked): 2012-05-15 Lucas Forschler Merge 116473 2012-05-08 Jon Lee Safari warns that it needs to resend the form in an iFrame when going back https://bugs.webkit.org/show_bug.cgi?id=82658 Reviewed by Darin Adler. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching. 2012-05-15 Lucas Forschler Merge 116449 2012-05-08 Timothy Hatcher Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen. Reviewed by Mark Rowe. * WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version. 2012-05-15 Lucas Forschler Merge 116367 2012-05-07 Andy Estes ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES. * Configurations/FeatureDefines.xcconfig: 2012-05-15 Lucas Forschler Merge 116356 2012-05-07 Eric Seidel Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed https://bugs.webkit.org/show_bug.cgi?id=85822 Reviewed by Adam Barth. * Configurations/FeatureDefines.xcconfig: 2012-05-04 Jer Noble REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests) https://bugs.webkit.org/show_bug.cgi?id=85674 Reviewed by Oliver Hunt. Null check the results of core([frame DOMDocument]). * WebView/WebView.mm: (-[WebView _didStartProvisionalLoadForFrame:]): 2012-05-02 Jer Noble Taking a visibility:hidden element full screen causes full screen window to disappear. https://bugs.webkit.org/show_bug.cgi?id=85432 Reviewed by Maciej Stachowiak. When given an initial or final frame with a zero width or height, return a rect representing the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will confuse the window server when it's instructed to scale the full screen window to that size. * WebView/WebFullScreenController.mm: (windowFrameFromApparentFrames): 2012-05-04 Jer Noble Full screen will exit during a provisional load of a non-ancestor iframe. https://bugs.webkit.org/show_bug.cgi?id=85230 Reviewed by Maciej Stachowiak . Only exit full screen mode if the frame being loaded contains the full screen element. * WebView/WebView.mm: (-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the request to close the full screen window when a provisional load occurs. 2012-05-04 Jer Noble Move WebKitFullScreenListener into its own file. https://bugs.webkit.org/show_bug.cgi?id=85640 Reviewed by Maciej Stachowiak. Move WebKitFullScreenListener into its own file, so it can be used by multiple classes. * WebCoreSupport/WebKitFullScreenListener.h: Added. * WebCoreSupport/WebKitFullScreenListener.mm: Added. (-[WebKitFullScreenListener webkitWillEnterFullScreen]): (-[WebKitFullScreenListener webkitDidEnterFullScreen]): (-[WebKitFullScreenListener webkitWillExitFullScreen]): (-[WebKitFullScreenListener webkitDidExitFullScreen]): * WebCoreSupport/WebChromeClient.mm: 2012-05-04 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception in [WebFrame loadRequest:] breaks some WebKit apps Reviewed by Alexey Proskuryakov. Some API clients pass in nil requests or requests with nil URLs. In r112571 we started rewriting these URLs resulting in an exception. Since we've supported nil requests until now, we should not try to rewrite these URLs. * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null. 2012-05-04 Nate Chapin Don't require FrameLoaderClient to manufacture a commitData() call for empty documents. https://bugs.webkit.org/show_bug.cgi?id=85533 Reviewed by Alexey Proskuryakov. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary, as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case. 2012-05-03 Anders Carlsson useWebKitWebInspector should be more robust against missing files https://bugs.webkit.org/show_bug.cgi?id=85563 Reviewed by Dan Bernstein. * WebCoreSupport/WebInspectorClient.mm: (useWebKitWebInspector): 2012-05-03 Tobias Netzel Bugs in WebFullScreenController https://bugs.webkit.org/show_bug.cgi?id=85388 Reviewed by Alexey Proskuryakov. Leopard specific fixes: NSWindow doesn't respond to isOnActiveSpace so find out first. Values passed to SetSystemUIMode were swapped. * WebView/WebFullScreenController.mm: (-[WebFullScreenController exitFullScreen]): (-[WebFullScreenController _updateMenuAndDockForFullScreen]): 2012-05-02 Jon Lee Migrate permission functions to Notification from NotificationCenter https://bugs.webkit.org/show_bug.cgi?id=80485 Reviewed by Jian Li. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: Add a separate callback variable depending on the notifications API enabled. (WebNotificationClient::requestPermission): Add NotificationPermissionCallback version of the same function. And refactor common code into private function. (-[WebNotificationPolicyListener initWithCallback:]): Refactor to take the NotificationPermissionCallback as a parameter. (-[WebNotificationPolicyListener initWithVoidCallback:]): Add new init method to handle legacy API. (-[WebNotificationPolicyListener allow]): Invoke the callback for both variables. If only one of the APIs is enabled, we are guaranteed that the relevant callback variable exists. If both APIs are supported, it is possible that _voidCallback will be nil if the callback is NotificationPermissionCallback, so we need the extra pointer check. (-[WebNotificationPolicyListener deny]): Ditto. 2012-05-02 Eric Seidel Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate) https://bugs.webkit.org/show_bug.cgi?id=85433 Reviewed by Adam Barth. I have a script which can autogenerate these xcconfig files as well as the vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists from a central feature list file. In preparation for posting such a tool, I'm re-sorting these xcconfig files to be alphabetically ordered (currently they're close, but not quite). There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which I will fix in a second pass. I will also sort the FEATURE_DEFINES = line in a follow-up patch. * Configurations/FeatureDefines.xcconfig: 2012-04-18 Jon Honeycutt FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted https://bugs.webkit.org/show_bug.cgi?id=84297 Reviewed by Andy Estes. * WebCoreSupport/WebFrameLoaderClient.h: Updated method declaration. 2012-05-01 Jon Honeycutt Make Page::setDefersLoading() have a call count so that each time loading is deferred, it must be balanced with a call to resume. https://bugs.webkit.org/show_bug.cgi?id=84522 Reviewed by Andy Estes. * WebView/WebPreferenceKeysPrivate.h: Declare a new key for this preference. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize new preference to NO. (-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]): Setter. (-[WebPreferences wantsBalancedSetDefersLoadingBehavior]): Getter. * WebView/WebPreferencesPrivate.h: Declare setter and getter. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Set the setting from the WebPreferences object's value. 2012-05-01 Jeffrey Pfau Support for web content filter delegate for filtering https content https://bugs.webkit.org/show_bug.cgi?id=85300 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-05-01 Ryosuke Niwa *Command.h files shouldn't be exported to WebKit layer https://bugs.webkit.org/show_bug.cgi?id=74778 Reviewed by Eric Seidel. * WebView/WebFrame.mm: (-[WebFrame _insertParagraphSeparatorInQuotedContent]): 2012-04-28 Geoffrey Garen Clarified JSGlobalData (JavaScript VM) lifetime https://bugs.webkit.org/show_bug.cgi?id=85142 Reviewed by Anders Carlsson. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): 2012-04-27 Gavin Peters Add new ENABLE_LINK_PRERENDER define to control the Prerendering API https://bugs.webkit.org/show_bug.cgi?id=84871 Reviewed by Adam Barth. Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering API separates it from prefetching. Having separate include guards lets ports enable prefetching, a relatively easy change, without needing to build the infrastructure for prerendering, which is considerably more complicated. 2012-04-26 Jon Lee [WK2] AlternativeTextClient leaks when the page is destroyed https://bugs.webkit.org/show_bug.cgi?id=84307 Reviewed by Enrica Casucci. * WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient. (WebAlternativeTextClient): * WebCoreSupport/WebAlternativeTextClient.mm: (WebAlternativeTextClient::pageDestroyed): Deletes itself. 2012-04-26 Jer Noble Full Screen mode does not preserve CALayer ordering after exiting. https://bugs.webkit.org/show_bug.cgi?id=83931 Reviewed by Eric Carlson. Further corrections to r114567. When swapping view for otherView, give the correct relative view to -[NSView addSubview:positioned:relativeTo:]. * WebView/WebFullScreenController.mm: (-[WebFullScreenController _swapView:with:]): 2012-04-25 Jer Noble Placeholder view is immediately removed from hosting window upon entering full screen. https://bugs.webkit.org/show_bug.cgi?id=84916 Reviewed by Darin Adler. Correct a mistake added in r114567. When swapping view for otherView, add otherView and remove view (rather than adding otherView and removing otherView). * WebView/WebFullScreenController.mm: (-[WebFullScreenController _swapView:with:]): 2012-04-25 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=84913 WebKit 1: Initialize deviceScaleFactor on creation of the WebView -and corresponding- Reviewed by Darin Adler. Before this patch, we weren't setting the deviceScaleFactor until viewDidMoveToWindow which is quite late for background tabs. setHostWindow will happen early on though. For applications that don't use host windows, also set it from _initWithFrame. * WebView/WebView.mm: (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView setHostWindow:]): (-[WebView _deviceScaleFactor]): 2012-04-24 Alexis Menard Replace occurences of style selector from variables and methods names by style resolver. https://bugs.webkit.org/show_bug.cgi?id=84765 Reviewed by Andreas Kling. Rename methods and variables to follow the new name StyleResolver. It requires to update the local variables, methods parameters, and function names to match the new name and to remove the concept of "selector" to avoid clashing with the CSS concept. The next and last patch will be to rename CSSStyleSelector file and update the includes. * WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): 2012-04-23 Andy Estes Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first. https://bugs.webkit.org/show_bug.cgi?id=84583 Add a private WebPreference for setting the incremental rendering suppression timeout. Reviewed by Anders Carlsson. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]): (-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-04-23 Julien Chaffraix Cut dependency on RenderLayer::scrollRectToVisible outside rendering https://bugs.webkit.org/show_bug.cgi?id=84607 Reviewed by Simon Fraser. * WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]): Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer. 2012-04-22 Jon Lee Remove notifications support on Mac Lion. https://bugs.webkit.org/show_bug.cgi?id=84554 Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2012-04-20 Jon Lee Add Notification constructor https://bugs.webkit.org/show_bug.cgi?id=80477 Reviewed by Jian Li. * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::clearNotifications): When clearing notifications, finalize them so that they can be cleaned up by the GC. 2012-04-20 Timothy Hatcher Make the Web Inspector be the first responder when opening docked. Reviewed by Brian Weinstein. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on the window and pass the Inspector's WebView. 2012-04-18 Hironori Bono Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled() https://bugs.webkit.org/show_bug.cgi?id=83748 Reviewed by Ryosuke Niwa. This change replaces a call for SpellChecker::didCheck() with one for SpellChecker::didCheckSucceeded() because didCheck has been split into didCheckSucceeded(0 and didCheckCanceled(). * WebCoreSupport/WebEditorClient.mm: (-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded. 2012-04-18 Jer Noble Full Screen mode does not preserve CALayer ordering after exiting. https://bugs.webkit.org/show_bug.cgi?id=83931 Reviewed by Eric Carlson. When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:] instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order of the view's backing CALayers. * WebView/WebFullScreenController.mm: (-[WebFullScreenController _swapView:with:]): 2012-04-18 Alexey Proskuryakov [WK2] Sandbox violations prevent attaching files to gmail messages https://bugs.webkit.org/show_bug.cgi?id=84263 Reviewed by Oliver Hunt. * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragDestinationAction): DragDestinationActionUpload no longer exists, so we don't need a special case for it. 2012-04-17 Jer Noble Exiting full screen video brings the wrong Safari window to the foreground https://bugs.webkit.org/show_bug.cgi?id=83936 Reviewed by Adele Peterson. Tell the original webView's window to makeKeyAndOrderFront once the exit animation completes. * WebView/WebFullScreenController.mm: (-[WebFullScreenController finishedExitFullScreenAnimation:]): 2012-04-16 Anders Carlsson Use a MIG call when creating a plug-in property list file https://bugs.webkit.org/show_bug.cgi?id=84084 Reviewed by Sam Weinig. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead. * Plugins/Hosted/WebKitPluginHost.defs: Add PHCreatePluginMIMETypesPreferences. * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): NetscapePluginHostManager::createPropertyListFile is no longer a static member function. 2012-04-12 Andy Estes REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important' https://bugs.webkit.org/show_bug.cgi?id=83832 Reviewed by Alexey Proskuryakov. * Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first version of WebKit.framework to ignore '!important' in CSSStyleDeclaration property setters. * WebView/WebView.mm: (shouldRespectPriorityInCSSAttributeSetters): (-[WebView _commonInitializationWithFrameName:groupName:]): Enable a quirk to restore pre-r102262 behavior if the application is iAd Producer and was linked against a version of WebKit.framework that had the old behavior. 2012-04-12 Andy Estes Remove unused WebKit1 SPI for suppressing incremental rendering. https://bugs.webkit.org/show_bug.cgi?id=83801 Reviewed by Simon Fraser. This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering). * WebView/WebPreferences.mm: * WebView/WebPreferencesPrivate.h: 2012-04-08 Dan Bernstein [mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html https://bugs.webkit.org/show_bug.cgi?id=83453 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning no custom scale factor, this method was setting the Page scale factor to 0, and that value was used by canvas. Changed it to correctly set the Page scale factor back to the device scale factor. 2012-04-06 Alexey Proskuryakov [Mac] Adopt a different method of telling AppKit when inline input isn't supported https://bugs.webkit.org/show_bug.cgi?id=83408 Reviewed by Adele Peterson. * Plugins/Hosted/WebTextInputWindowController.m: (-[WebTextInputView validAttributesForMarkedText]): (-[WebTextInputPanel init]): (-[WebTextInputPanel _interpretKeyEvent:string:]): Added a comment about old approach. 2012-04-06 Enrica Casucci Provide Obj-C private API to simplify markup. https://bugs.webkit.org/show_bug.cgi?id=83334 Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _simplifyMarkup:endNode:]): Added. * WebView/WebViewPrivate.h: 2012-04-06 Tim Horton Add autodetection of image orientation from EXIF information https://bugs.webkit.org/show_bug.cgi?id=19688 and Original patch by David Carson and Eric Seidel. Reviewed by Simon Fraser. Add a preference, ShouldRespectImageOrientation, which will cause WebCore to respect EXIF orientation in all images. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setShouldRespectImageOrientation:]): (-[WebPreferences shouldRespectImageOrientation]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-04-06 Dan Bernstein HiDPI: Have canvas use a hidpi backing store, but downsample upon access Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS. 2012-04-05 Jia Pu Move correction panel related functions from EditorClient into separated AlternativeTextClient class. https://bugs.webkit.org/show_bug.cgi?id=82970 Reviewed by Enrica Casucci. Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient. See WebCore/ChangeLog for details. * WebCoreSupport/CorrectionPanel.h: * WebCoreSupport/CorrectionPanel.mm: * WebCoreSupport/WebAlternativeTextClient.h: Added. (WebAlternativeTextClient): * WebCoreSupport/WebAlternativeTextClient.mm: Added. (WebAlternativeTextClient::WebAlternativeTextClient): (WebAlternativeTextClient::~WebAlternativeTextClient): (WebAlternativeTextClient::showCorrectionAlternative): (WebAlternativeTextClient::dismissAlternative): (WebAlternativeTextClient::dismissAlternativeSoon): (WebAlternativeTextClient::recordAutocorrectionResponse): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::~WebEditorClient): * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2012-03-15 Jer Noble Full Screen mode should cancel before navigation. https://bugs.webkit.org/show_bug.cgi?id=81295 Reviewed by Anders Carlsson. When a provisional load is started, if the page is currently in full screen mode, instruct the full screen controller to close the full screen window immediately. * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController isFullScreen]): Added. * WebView/WebView.mm: (-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if present and in full screen mode. 2012-04-03 Keishi Hattori Disable ENABLE_DATALIST for now https://bugs.webkit.org/show_bug.cgi?id=82871 Reviewed by Kent Tamura. * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST. 2012-04-03 Anders Carlsson Add audit token to PHCheckInWithPluginHost https://bugs.webkit.org/show_bug.cgi?id=83102 Reviewed by Sam Weinig. * Plugins/Hosted/WebKitPluginHost.defs: 2012-04-02 Jia Pu Rename SpellingCorrectionController to AlternativeTextController. https://bugs.webkit.org/show_bug.cgi?id=82942 Reviewed by Enrica Casucci. These changes are simply adopting new class names. * WebCoreSupport/CorrectionPanel.h: (CorrectionPanel): * WebCoreSupport/CorrectionPanel.mm: (correctionIndicatorType): (CorrectionPanel::CorrectionPanel): (CorrectionPanel::~CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissInternal): (CorrectionPanel::handleAcceptedReplacement): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::~WebEditorClient): (WebEditorClient::showCorrectionPanel): (WebEditorClient::dismissCorrectionPanel): (WebEditorClient::dismissCorrectionPanelSoon): * WebView/WebView.mm: (-[WebView handleCorrectionPanelResult:]): 2012-04-03 Jer Noble ESC key in full screen does not result in webkitFullScreenChange event. https://bugs.webkit.org/show_bug.cgi?id=82755 Reviewed by Eric Carlson. Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent out correctly. * WebView/WebFullScreenController.mm: (-[WebFullScreenController cancelOperation:]): (-[WebFullScreenController requestExitFullScreen]): 2012-04-01 Jon Lee Rename notification properties and functions https://bugs.webkit.org/show_bug.cgi?id=80482 Reviewed by Kentaro Hara. * WebView/WebNotification.h: Rename replaceID to tag. * WebView/WebNotification.mm: (-[WebNotification tag]): 2012-03-31 Timothy Hatcher Prevent opening external URLs in the Web Inspector's WebView. All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView. https://webkit.org/b/82812 rdar://problem/9488558 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath. (-[WebInspectorWindowController inspectorPagePath]): Added. (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added. Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page. 2012-03-30 Emil A Eklund Change WebKit/WebKit2 platform code to use pixel snapped values https://bugs.webkit.org/show_bug.cgi?id=82549 Change WebKit and WebKit2 platform code to use rounded locations and pixel snapped rects and sizes. This largely avoids having to expose the fractional layout types to the platform code. Reviewed by Eric Seidel. * DOM/WebDOMOperations.mm: (-[DOMNode _renderRect:]): 2012-03-30 Mark Pilgrim GEOLOCATION should be implemented as Page Supplement https://bugs.webkit.org/show_bug.cgi?id=82228 Reviewed by Adam Barth. Geolocation is now a Supplement in Page so the interface has changed for setting up the page's geolocation client initially and accessing the controller later. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _geolocationDidChangePosition:]): (-[WebView _geolocationDidFailWithError:]): 2012-03-30 Keishi Hattori Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium https://bugs.webkit.org/show_bug.cgi?id=80972 Reviewed by Kent Tamura. * Configurations/FeatureDefines.xcconfig: 2012-03-28 Alexey Proskuryakov [Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications https://bugs.webkit.org/show_bug.cgi?id=82548 Reviewed by Brady Eidson. * WebView/WebFrame.mm: (-[WebFrame loadRequest:]): Fixed this bug. (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't have to come back again. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto. * WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used to pass file paths instead of URLs. 2012-03-29 Sheriff Bot Unreviewed, rolling out r112553. http://trac.webkit.org/changeset/112553 https://bugs.webkit.org/show_bug.cgi?id=82638 It made all tests crash on Qt WK2 (Requested by Ossy_away on #webkit). * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _geolocationDidChangePosition:]): (-[WebView _geolocationDidFailWithError:]): 2012-03-29 Caio Marcelo de Oliveira Filho HashMap<>::add should return a more descriptive object https://bugs.webkit.org/show_bug.cgi?id=71063 Reviewed by Ryosuke Niwa. Update code to use AddResult instead of a pair. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed): * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::show): 2012-03-29 Mark Pilgrim GEOLOCATION should be implemented as Page Supplement https://bugs.webkit.org/show_bug.cgi?id=82228 Reviewed by Adam Barth. Geolocation is now a Supplement in Page so the interface has changed for setting up the page's geolocation client initially and accessing the controller later. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _geolocationDidChangePosition:]): (-[WebView _geolocationDidFailWithError:]): 2012-03-28 Nate Chapin Remove dispatchDidLoadMainResource callback, since no port implements it. https://bugs.webkit.org/show_bug.cgi?id=82539 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: * WebKit.order: 2012-03-28 Joseph Pecoraro Web Inspector: Create -[DOMNode inspect] from IDL Reviewed by Timothy Hatcher. * MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders. 2012-03-27 Timothy Hatcher Make WebKit properly load a staged framework when soft linking. https://webkit.org/b/82371 rdar://problem/11125989 Reviewed by Dan Bernstein. * WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly load the WebInspector framework. 2012-03-26 Adam Barth FrameLoader::shouldAllowNavigation uses Frame for context rather than Document https://bugs.webkit.org/show_bug.cgi?id=81020 Reviewed by Eric Seidel. Update call site to new function name. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): 2012-03-23 Alexey Proskuryakov [Mac] No need for platform-specific ENABLE_BLOB values https://bugs.webkit.org/show_bug.cgi?id=82102 Reviewed by David Kilzer. * Configurations/FeatureDefines.xcconfig: 2012-03-23 Dean Jackson Disable CSS_SHADERS in Apple builds https://bugs.webkit.org/show_bug.cgi?id=81996 Reviewed by Simon Fraser. Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h. * Configurations/FeatureDefines.xcconfig: 2012-03-22 Gyuyoung Kim Convert hasGrammarMarker to use Internals interface https://bugs.webkit.org/show_bug.cgi?id=82004 Reviewed by Ryosuke Niwa. Remove hasGrammarMarker support, since it can support in the cross-port way through the Internals interface. * WebKit.order: * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2012-03-22 Benjamin Poulain Build fix for WebHistory is busted after changing time zone https://bugs.webkit.org/show_bug.cgi?id=81849 Unreviewed build fix. When generating warning for undefined message signature, rebuildHistoryByDayIfNeeded fail to compile due to addItemToDateCaches: being undefined. Move the definition to the right place in the file to use the private method. * History/WebHistory.mm: (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]): 2012-03-22 Benjamin Poulain WebHistory is busted after changing time zone https://bugs.webkit.org/show_bug.cgi?id=81849 Reviewed by Brady Eidson. The date used for choosing the bucket of a new entry is computed with the system TimeZone. When the Time Zone change, or the daylight saving time change, all the dates in _entriesByDate are offset from the new entries. This patch solves the issue by re-distributing the WebHistoryItems if the time zone changes. The clients of WebHistory are notified of this change through the regular Notifications. * History/WebHistory.mm: (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]): (-[WebHistoryPrivate init]): (-[WebHistory timeZoneChanged:]): (-[WebHistory init]): (-[WebHistory dealloc]): (-[WebHistory finalize]): 2012-03-21 Tim Horton Make use of CG rounded-rect primitives https://bugs.webkit.org/show_bug.cgi?id=79932 Reviewed by Simon Fraser. Portions of patch by Nikolas Zimmermann and Mustafizur Rahaman. Add wkCGPathAddRoundedRect. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-03-20 Gyuyoung Kim Convert hasSpellingMarker to use Internals interface. https://bugs.webkit.org/show_bug.cgi?id=81300 Reviewed by Ryosuke Niwa. Remove hasSpellingMarker support, since it can support in the cross-port way through the Internals interface. * WebKit.order: * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2012-03-19 Adam Barth Remove support for "magic" iframe https://bugs.webkit.org/show_bug.cgi?id=81590 Reviewed by Eric Seidel. Remove FrameLoaderClient methods that no longer exist. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: 2012-03-19 Enrica Casucci WebKit2: create sandbox extensions for files that are dropped in an input control. https://bugs.webkit.org/show_bug.cgi?id=81153 Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action. We want to avoid any unwanted side effects for the WebKit clients. 2012-03-19 Emil A Eklund [mac/chromium] Change platform code to use pixelSnappedRect methods https://bugs.webkit.org/show_bug.cgi?id=81016 Reviewed by Eric Seidel. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView actualVisibleRectInWindow]): * WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): * WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView trackedRepaintRects]): 2012-03-16 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted Reviewed by Geoff Garen. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setInsertionPasteboard): * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::url): 2012-03-08 Jer Noble Support W3C Full Screen API proposal https://bugs.webkit.org/show_bug.cgi?id=80660 Reviewed by Alexey Proskuryakov. Allow full screen elements to access the keyboard. * WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): 2012-03-07 Jon Lee Move NotificationContents into Notification https://bugs.webkit.org/show_bug.cgi?id=80487 Reviewed by Jian Li. * WebView/WebNotification.mm: Refactor to use accessor methods on Notification. (-[WebNotification title]): (-[WebNotification body]): 2012-03-15 David Hyatt https://bugs.webkit.org/show_bug.cgi?id=81258 Add a preference for enabling the new multi-column layout code that will be based on regions. Reviewed by Beth Dakin. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setRegionBasedColumnsEnabled:]): (-[WebPreferences regionBasedColumnsEnabled]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-03-15 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=81079 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard Reviewed by Sam Weinig. Add the non-destructive "addTypes" to supplement the destructive "setTypes" * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::addTypes): 2012-03-14 Anders Carlsson java/java-and-plugins.html test failing https://bugs.webkit.org/show_bug.cgi?id=81188 Reviewed by Sam Weinig. When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the current plug-in instance is the same as the plug-in instance the object came from and don't pass the unwrapped object ID if that is the case. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::getObjectID): (WebKit::NetscapePluginInstanceProxy::addValueToArray): (WebKit::NetscapePluginInstanceProxy::marshalValues): * Plugins/Hosted/ProxyInstance.h: (ProxyInstance): (WebKit::ProxyInstance::instanceProxy): 2012-03-14 Michael Saboff REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots https://bugs.webkit.org/show_bug.cgi?id=80993 Reviewed by Mark Rowe. Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH to fix builds given the wtf move. * Configurations/WebKit.xcconfig: 2012-03-13 Jon Lee Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS https://bugs.webkit.org/show_bug.cgi?id=80922 Reviewed by Jian Li. You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API. LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the new API. Therefore, APIs that are common between the two will have: #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to the new API, the defines will begin to split. This allows ports to decide which set of APIs to include. Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS) * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::show): (WebNotificationClient::cancel): (WebNotificationClient::clearNotifications): (WebNotificationClient::notificationObjectDestroyed): (WebNotificationClient::notificationControllerDestroyed): (WebNotificationClient::requestPermission): (WebNotificationClient::checkPermission): * WebView/WebNotification.mm: (-[WebNotification title]): (-[WebNotification body]): (-[WebNotification replaceID]): (-[WebNotification origin]): (-[WebNotification notificationID]): (-[WebNotification dispatchShowEvent]): (-[WebNotification dispatchCloseEvent]): (-[WebNotification dispatchClickEvent]): (-[WebNotification dispatchErrorEvent]): * WebView/WebNotificationInternal.h: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2012-03-13 Adam Barth && Benjamin Poulain Always enable ENABLE(CLIENT_BASED_GEOLOCATION) https://bugs.webkit.org/show_bug.cgi?id=78853 Reviewed by Adam Barth. * Configurations/FeatureDefines.xcconfig: * WebCoreSupport/WebChromeClient.h: (WebChromeClient): * WebCoreSupport/WebGeolocationClient.mm: (WebGeolocationClient::lastPosition): * WebView/WebGeolocationPosition.mm: (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]): (core): (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]): * WebView/WebGeolocationPositionInternal.h: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _geolocationDidChangePosition:]): (-[WebView _geolocationDidFailWithError:]): 2012-03-12 Antonio Gomes Convert nodesFromRect tests to use Internals interface https://bugs.webkit.org/show_bug.cgi?id=80886 Reviewed by Ryosuke Niwa. Removed mac specific support for nodesFromRect for testing purposes only, since it can work in a cross-port way through the Internals interface. * WebKit.order: * WebView/WebView.mm: * WebView/WebViewPrivate.h: 2012-03-13 Anders Carlsson Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h https://bugs.webkit.org/show_bug.cgi?id=81014 Reviewed by Sam Weinig. Remove a plug-in halter related WebUIDelegate method. * WebView/WebUIDelegatePrivate.h: 2012-03-13 Shinya Kawanaka REGRESSION: Spellcheck tests hit assertions on Mac. https://bugs.webkit.org/show_bug.cgi?id=80883 Reviewed by Ryosuke Niwa. The bug was caused by the closure object created in requestCheckingOfString accessing request's member variables even though the request object is not an NSObject or allocated in stack. This resulted in the closure not being able to access those variables when invoked. Fixed the bug by making local copies of those member variables. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::requestCheckingOfString): 2012-03-11 Timothy Hatcher Update how the Web Inspector resources are loaded. https://bugs.webkit.org/show_bug.cgi?id=80798 rdar://problem/10359959 Reviewed by Brian Weinstein. * WebCoreSupport/WebInspectorClient.mm: (useWebKitWebInspector): Return if we are using the WebCore resources for compatibility with local and nightly builds. (WebInspectorFrontendClient::localizedStringsURL): Decide what path to use. (-[WebInspectorWindowController init]): Ditto. (-[WebInspectorWindowController window]): Decide if the window is textured or not. 2012-03-09 Jon Lee Rename NotificationPresenter to NotificationClient https://bugs.webkit.org/show_bug.cgi?id=80488 Reviewed by Kentaro Hara. Refactor to use renamed WebCore::NotificationClient. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::checkPermission): * WebView/WebViewPrivate.h: 2012-03-09 Enrica Casucci Move WebNSURLExtras code down to WebCore. https://bugs.webkit.org/show_bug.cgi?id=80611 Reviewed by Alexey Proskuryakov. Changed the implementation to use newly moved WebCore functions. * Misc/WebKitNSStringExtras.mm: (-[NSString _webkit_hasCaseInsensitivePrefix:]): * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithUserTypedString:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_userVisibleString]): (-[NSURL _web_isEmpty]): (-[NSURL _web_URLCString]): (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _web_URLByRemovingUserInfo]): (-[NSURL _web_dataForURLComponentType:]): (-[NSURL _web_schemeData]): (-[NSURL _web_hostData]): (-[NSString _web_isUserVisibleURL]): (-[NSString _web_hostNameNeedsDecodingWithRange:]): (-[NSString _web_hostNameNeedsEncodingWithRange:]): (-[NSString _web_decodeHostNameWithRange:]): (-[NSString _web_encodeHostNameWithRange:]): (-[NSString _web_decodeHostName]): (-[NSString _web_encodeHostName]): * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-03-09 Emil A Eklund Add roundedPoint to HitTestResult and change platform code to use it https://bugs.webkit.org/show_bug.cgi?id=80715 Reviewed by James Robinson. Change ports to use roundedPoint to avoid exposing subpixel types to platform code. * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::showContextMenu): 2012-03-09 Jon Lee Add support for ENABLE(LEGACY_NOTIFICATIONS) https://bugs.webkit.org/show_bug.cgi?id=80497 Reviewed by Adam Barth. Prep for b80472: Update API for Web Notifications * Configurations/FeatureDefines.xcconfig: 2012-03-08 Ryosuke Niwa Mac build fix for micro data API. * Configurations/FeatureDefines.xcconfig: 2012-03-08 Jer Noble Unreviewed Snow Leopard build fix. On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:]. * WebView/WebFullScreenController.mm: (-[NSWindow convertRectToScreen:]): 2012-02-20 Jer Noble Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition. https://bugs.webkit.org/show_bug.cgi?id=78930 Reviewed by Anders Carlsson. Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController: * WebView/WebFullScreenController.mm: (-[WebFullScreenController init]): (-[WebFullScreenController dealloc]): (-[WebFullScreenController windowDidLoad]): (-[WebFullScreenController cancelOperation:]): (-[WebFullScreenController applicationDidResignActive:]): (-[WebFullScreenController applicationDidChangeScreenParameters:]): (-[WebFullScreenController finishedEnterFullScreenAnimation:]): (-[WebFullScreenController finishedExitFullScreenAnimation:]): (-[WebFullScreenController close]): (-[WebFullScreenController animationDidEnd:]): (-[WebFullScreenController _updateMenuAndDockForFullScreen]): (-[WebFullScreenController _swapView:with:]): (createBackgroundFullscreenWindow): (windowFrameFromApparentFrames): (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): The following is a copy of the equivalent function in WebFullScreenManager: * WebView/WebFullScreenController.mm: (screenRectOfContents): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.) * WebView/WebFullScreenController.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController setElement:]): No need to add event listeners to the media element. (-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous. (-[WebFullScreenController exitFullScreen]): Ditto. * WebView/WebView.mm: (-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen. (-[WebView _exitFullScreenForElement:WebCore::]): Ditto. 2012-03-08 Matt Lilek Don't enable VIDEO_TRACK on all OS X platforms https://bugs.webkit.org/show_bug.cgi?id=80635 Reviewed by Eric Carlson. * Configurations/FeatureDefines.xcconfig: 2012-03-07 Joseph Pecoraro Web Inspector crash (iCab) Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::didResizeMainFrame): 2012-03-06 Benjamin Poulain [Mac] Update the configuration files for iOS https://bugs.webkit.org/show_bug.cgi?id=80435 Reviewed by David Kilzer. * Configurations/WebKit.xcconfig: 2012-03-06 Eric Seidel Make WTF public headers use fully-qualified include paths and remove ForwardingHeaders/wtf https://bugs.webkit.org/show_bug.cgi?id=80363 Reviewed by Mark Rowe. ForwardingHeaders/wtf is no longer necessary (or functional) now that JavaScriptCore no longer includes the WTF headers as private headers. * ForwardingHeaders/wtf/ASCIICType.h: Removed. * ForwardingHeaders/wtf/AlwaysInline.h: Removed. * ForwardingHeaders/wtf/Assertions.h: Removed. * ForwardingHeaders/wtf/Deque.h: Removed. * ForwardingHeaders/wtf/DisallowCType.h: Removed. * ForwardingHeaders/wtf/FastMalloc.h: Removed. * ForwardingHeaders/wtf/Forward.h: Removed. * ForwardingHeaders/wtf/GetPtr.h: Removed. * ForwardingHeaders/wtf/HashCountedSet.h: Removed. * ForwardingHeaders/wtf/HashMap.h: Removed. * ForwardingHeaders/wtf/HashSet.h: Removed. * ForwardingHeaders/wtf/HashTraits.h: Removed. * ForwardingHeaders/wtf/ListHashSet.h: Removed. * ForwardingHeaders/wtf/ListRefPtr.h: Removed. * ForwardingHeaders/wtf/Locker.h: Removed. * ForwardingHeaders/wtf/MathExtras.h: Removed. * ForwardingHeaders/wtf/Noncopyable.h: Removed. * ForwardingHeaders/wtf/OwnArrayPtr.h: Removed. * ForwardingHeaders/wtf/OwnPtr.h: Removed. * ForwardingHeaders/wtf/OwnPtrCommon.h: Removed. * ForwardingHeaders/wtf/PassOwnPtr.h: Removed. * ForwardingHeaders/wtf/PassRefPtr.h: Removed. * ForwardingHeaders/wtf/Platform.h: Removed. * ForwardingHeaders/wtf/RefCounted.h: Removed. * ForwardingHeaders/wtf/RefCountedLeakCounter.h: Removed. * ForwardingHeaders/wtf/RefPtr.h: Removed. * ForwardingHeaders/wtf/RetainPtr.h: Removed. * ForwardingHeaders/wtf/StdLibExtras.h: Removed. * ForwardingHeaders/wtf/TemporaryChange.h: Removed. * ForwardingHeaders/wtf/Threading.h: Removed. * ForwardingHeaders/wtf/UnusedParam.h: Removed. * ForwardingHeaders/wtf/VMTags.h: Removed. * ForwardingHeaders/wtf/ValueCheck.h: Removed. * ForwardingHeaders/wtf/Vector.h: Removed. * ForwardingHeaders/wtf/VectorTraits.h: Removed. * ForwardingHeaders/wtf/unicode/Unicode.h: Removed. * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed. 2012-03-05 Joseph Pecoraro Web Inspector: Hide dock button when not allowed to dock https://bugs.webkit.org/show_bug.cgi?id=78575 Reviewed by Pavel Feldman. * WebCoreSupport/WebInspectorClient.h: (WebCore): (WebInspectorClient): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::didResizeMainFrame): 2012-03-05 Gavin Barraclough putByIndex should throw in strict mode https://bugs.webkit.org/show_bug.cgi?id=80335 Reviewed by Filip Pizlo. Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::setProperty): 2012-03-05 Joseph Pecoraro Unreviewed rollout of r109858 for restructuring. 2012-03-05 Joseph Pecoraro Web Inspector: Hide dock button when not allowed to dock Reviewed by Timothy Hatcher. * WebCoreSupport/WebInspectorClient.h: (WebInspectorClient): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::updateDockingAvailability): 2012-03-02 Jon Lee Add support for notification replaceId in Mac WebKit and WK2 https://bugs.webkit.org/show_bug.cgi?id=80206 Reviewed by Sam Weinig. * WebView/WebNotification.h: Add replaceID method. * WebView/WebNotification.mm: (-[WebNotification replaceID]): 2012-03-05 Adam Barth Geolocation should use a ScriptExecutionContext as its context object https://bugs.webkit.org/show_bug.cgi?id=80248 Reviewed by Kentaro Hara. * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): - We no longer special-case Geolocation. 2012-03-03 Benjamin Poulain Remove the redundant method KURL::protocolInHTTPFamily() https://bugs.webkit.org/show_bug.cgi?id=80216 Reviewed by Anders Carlsson. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): 2012-03-03 Hans Wennborg Implement Speech JavaScript API https://bugs.webkit.org/show_bug.cgi?id=80019 Reviewed by Adam Barth. Add ENABLE_SCRIPTED_SPEECH. * Configurations/FeatureDefines.xcconfig: 2012-03-03 Anders Carlsson Fix build with newer versions of clang. * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Use %ld and cast to long. * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type. 2012-03-01 Nikolas Zimmermann Unreviewed, rolling out r109255. http://trac.webkit.org/changeset/109255 https://bugs.webkit.org/show_bug.cgi?id=79932 Breaks rounded rects with dashed strokes in SVG * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-02-29 Adam Barth ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE) https://bugs.webkit.org/show_bug.cgi?id=79633 Reviewed by Eric Seidel. * WebView/WebFrame.mm: (-[WebFrame _cacheabilityDictionary]): 2012-02-29 Tim Horton Make use of CG rounded-rect primitives https://bugs.webkit.org/show_bug.cgi?id=79932 Reviewed by Simon Fraser. Add wkCGPathAddRoundedRect. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-02-29 Enrica Casucci Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:] https://bugs.webkit.org/show_bug.cgi?id=79937 Reviewed by Dan Bernstein. * WebView/WebFrame.mm: (-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check. 2012-02-28 Simon Fraser Update WebKitSystemInterface. Reviewed by Sam Weinig. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2012-02-28 Enrica Casucci More Pasteboard code cleanup. https://bugs.webkit.org/show_bug.cgi?id=79816 Removing the last references to NSPasteboard. Reviewed by Alexey Proskuryakov. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setInsertionPasteboard): 2012-02-26 Hajime Morrita Move ChromeClient::showContextMenu() to ContextMenuClient https://bugs.webkit.org/show_bug.cgi?id=79427 Reviewed by Adam Barth. * WebCoreSupport/WebContextMenuClient.h: (WebContextMenuClient): * WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::showContextMenu): Moved from WebChromeClient * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: 2012-02-25 Sam Weinig QuickLook events don't make it to WebKit plugins. Reviewed by Anders Carlsson. * WebView/WebHTMLView.mm: (isQuickLookEvent): (-[WebHTMLView hitTest:]): Allow QuickLook events to hit test down to subviews. 2012-02-24 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=79421 Need a WK1 Mac API to filter which subframes go into WebArchives as they are created Reviewed by Sam Weinig (with additional comments by Adam Roben) Add webArchiveByFilteringSubframes: which takes a callback block: * DOM/WebDOMOperationsPrivate.h: Add FrameFilter that adapts the block, and use it to implement the new SPI: * DOM/WebDOMOperations.mm: (WebFrameFilter): (WebFrameFilter::WebFrameFilter): (WebFrameFilter::~WebFrameFilter): (WebFrameFilter::shouldIncludeSubframe): (-[DOMNode webArchiveByFilteringSubframes:]): 2012-02-24 Shinya Kawanaka SpellCheckRequest needs to know the context where the spellcheck happened. https://bugs.webkit.org/show_bug.cgi?id=79320 Reviewed by Hajime Morita. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::requestCheckingOfString): 2012-02-23 Andy Estes Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API. https://bugs.webkit.org/show_bug.cgi?id=79433 Reviewed by Dan Bernstein. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setSuppressesIncrementalRendering:]): (-[WebPreferences suppressesIncrementalRendering]): (-[WebPreferences setSuppressIncrementalRendering:]): (-[WebPreferences suppressIncrementalRendering]): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-02-22 Hajime Morrita NOTIFICATIONS should be implemented as PageSupplement https://bugs.webkit.org/show_bug.cgi?id=79052 Reviewed by Adam Barth. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2012-02-21 Ryosuke Niwa Remove the remaining uses of CSSStyleDeclaration in Editor https://bugs.webkit.org/show_bug.cgi?id=78939 Reviewed by Enrica Casucci. * WebCoreSupport/WebEditorClient.h: (WebEditorClient): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldApplyStyle): * WebView/WebFrame.mm: (-[WebFrame _setTypingStyle:withUndoAction:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): * WebView/WebView.mm: (-[WebView applyStyle:]): 2012-02-22 Ryosuke Niwa Remove the remaining uses of CSSStyleDeclaration in Editor https://bugs.webkit.org/show_bug.cgi?id=78939 Reviewed by Enrica Casucci. * WebCoreSupport/WebEditorClient.h: (WebEditorClient): * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldApplyStyle): * WebView/WebFrame.mm: (-[WebFrame _setTypingStyle:withUndoAction:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]): * WebView/WebView.mm: (-[WebView applyStyle:]): 2012-02-22 Jon Lee Part of r108409 was incorrect, and incorporated an older version of a sub-patch. This is the actual sub-patch that should have been submitted. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::show): (WebNotificationClient::cancel): (WebNotificationClient::clearNotifications): (WebNotificationClient::notificationObjectDestroyed): (WebNotificationClient::notificationControllerDestroyed): 2012-02-21 Jon Lee Build fix. Push ENABLE_NOTIFICATIONS into .mm file. * WebCoreSupport/WebNotificationClient.h: * WebView/WebNotification.h: * WebView/WebNotification.mm: (-[WebNotification title]): (-[WebNotification body]): (-[WebNotification origin]): (-[WebNotification notificationID]): (-[WebNotification dispatchShowEvent]): (-[WebNotification dispatchCloseEvent]): (-[WebNotification dispatchClickEvent]): (-[WebNotification dispatchErrorEvent]): 2012-02-21 John Sullivan Build fix. * WebView/WebUIDelegatePrivate.h: Added @class declarations for DOMNode and DOMElement. 2012-02-21 Jon Lee Build fix for r108409. * WebCoreSupport/WebNotificationClient.h: (WebCore): * WebCoreSupport/WebNotificationClient.mm: * WebView/WebNotification.h: (WebSecurityOrigin): * WebView/WebNotification.mm: (core): (-[WebNotification initWithCoreNotification:notificationID:]): 2012-02-21 Jon Lee Bring notifications support to WK1 mac: permission requests https://bugs.webkit.org/show_bug.cgi?id=78783 Reviewed by Anders Carlsson. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the WebAllowDenyPolicyListener protocol, similar to geolocation. (WebNotificationClient::requestPermission): (WebNotificationClient::checkPermission): (-[WebNotificationPolicyListener initWithCallback:]): (-[WebNotificationPolicyListener allow]): Call the callback. (-[WebNotificationPolicyListener deny]): Call the callback. * WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a policy for navigations. ==== Bring notifications support to WK1 mac: showing, canceling, removing notifications Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned ID. * WebView/WebNotification.h: Added. (WebSecurityOrigin): * WebView/WebNotification.mm: Added. (core): (-[WebNotification initWithCoreNotification:notificationID:]): (-[WebNotification init]): (-[WebNotification dealloc]): (-[WebNotification title]): (-[WebNotification body]): (-[WebNotification origin]): (-[WebNotification notificationID]): (-[WebNotification dispatchShowEvent]): (-[WebNotification dispatchCloseEvent]): (-[WebNotification dispatchClickEvent]): (-[WebNotification dispatchErrorEvent]): * WebView/WebNotificationInternal.h: Added. (WebCore): Internal category to allow creating instances with WebCore objects. Extend WebView to include a WebNotificationProvider, which clients implement. * WebView/WebViewData.h: Add a private member for the provider. * WebView/WebViewPrivate.h: * Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission that client which implement the provider can use to return policy decisions. * Define WebNotificationProvider. * Category WebViewNotification extends WebView with methods that set and manager the notification provider, and handle events from the platform notifications. * WebView/WebView.mm: (-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView. (-[WebView _notificationControllerDestroyed]): (-[WebView _notificationProvider]): (-[WebView _notificationDidShow:]): (-[WebView _notificationDidClick:]): (-[WebView _notificationsDidClose:]): * WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects. * WebCoreSupport/WebNotificationClient.mm: (generateNotificationID): Created unique IDs for each shown notification. (WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the mappings between the objects, and forward it to the provider. (WebNotificationClient::cancel): (WebNotificationClient::clearNotifications): Clear all notifications associated with the provided context. (WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps. (WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell the provider to clear of the notifications related to this web view. ==== (Prep work for) Bring notifications support to WK1 mac Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for notification requests. To avoid having to create a new listener type, instead rename it to WebAllowDenyPolicyListener. * WebView/WebUIDelegatePrivate.h: Rename the protocol. * WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use new name. Add preference to keep track of whether notifications are enabled in general. * WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the preference. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): By default have them enabled. (-[WebPreferences setNotificationsEnabled:]): (-[WebPreferences notificationsEnabled]): * WebView/WebPreferencesPrivate.h: Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the notification policy for a given origin. * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin stringValue]): * WebCoreSupport/WebSecurityOriginPrivate.h: 2012-02-21 Sam Weinig Attempt to fix the Snow Leopard build. * Configurations/Base.xcconfig: 2012-02-21 Sam Weinig Use libc++ when building with Clang on Mac https://bugs.webkit.org/show_bug.cgi?id=78981 Reviewed by Dan Bernstein. * Configurations/Base.xcconfig: 2012-02-17 Mihnea Ovidenie CSS regions enabled by default https://bugs.webkit.org/show_bug.cgi?id=78525 Reviewed by David Hyatt. Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled). CSSRegions are still enabled by default. In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences cssRegionsEnabled]): (-[WebPreferences setCSSRegionsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-02-17 Enrica Casucci Refactor DragData class to use PlatformStrategies in the Mac implementation. https://bugs.webkit.org/show_bug.cgi?id=78768 Reviewed by Darin Adler. * WebCoreSupport/WebPlatformStrategies.h: Added color() method. * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::color): 2012-02-16 Brady Eidson and https://bugs.webkit.org/show_bug.cgi?id=78767 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages Reviewed by Sam Weinig. * WebView/WebView.mm: (-[WebView _needsIsLoadingInAPISenseQuirk]): (-[WebView _preferencesChanged:]): 2012-02-15 Enrica Casucci Refactor ClipboardMac class to use PlatformStrategies. https://bugs.webkit.org/show_bug.cgi?id=78554 Reviewed by Anders Carlsson. * WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard. * WebCoreSupport/WebDragClient.mm: Ditto. (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::declareAndWriteDragImage): * WebCoreSupport/WebPlatformStrategies.h: Added new methods. * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::changeCount): (WebPlatformStrategies::uniqueName): 2012-02-15 Sadrul Habib Chowdhury Notify ChromeClient when touch-event handlers are installed/removed. https://bugs.webkit.org/show_bug.cgi?id=77440 Reviewed by Darin Fisher and Ryosuke Niwa. * WebCoreSupport/WebChromeClient.h: 2012-02-14 Matt Lilek Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms https://bugs.webkit.org/show_bug.cgi?id=78629 Reviewed by David Kilzer. * Configurations/FeatureDefines.xcconfig: 2012-02-14 Alexey Proskuryakov [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets https://bugs.webkit.org/show_bug.cgi?id=78541 Reviewed by Kent Tamura. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the preference. 2012-02-11 Nikolas Zimmermann Convert svg/animations to use SMIL methods for driving the timeline https://bugs.webkit.org/show_bug.cgi?id=78422 Reviewed by Dirk Schulze. Remove SVG animation sampling functionality provided for DRT, which no longer uses it. Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime. * WebKit.order: * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2012-02-13 Enrica Casucci Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies. https://bugs.webkit.org/show_bug.cgi?id=78282 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which now makes use of a new pasteboardStrategy object that is implemented both in WebKit and WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy interface but this one more step in the direction of removing access to NSPasteboard from the WebProcess. As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes. Reviewed by Anders Carlsson. * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy. * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::getTypes): (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::getPathnamesForType): (WebPlatformStrategies::stringForType): (WebPlatformStrategies::copy): (WebPlatformStrategies::setTypes): (WebPlatformStrategies::setBufferForType): (WebPlatformStrategies::setPathnamesForType): (WebPlatformStrategies::setStringForType): 2012-02-12 Hajime Morrita Page should have less intrusive way to associate API implementation objects. https://bugs.webkit.org/show_bug.cgi?id=78085 Reviewed by Adam Barth. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2012-02-11 Sheriff Bot Unreviewed, rolling out r107435. http://trac.webkit.org/changeset/107435 https://bugs.webkit.org/show_bug.cgi?id=78410 It broke the Qt build (Requested by Ossy on #webkit). * WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies): * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::addVisitedLink): 2012-02-10 Adam Klein Enable MUTATION_OBSERVERS by default on all platforms https://bugs.webkit.org/show_bug.cgi?id=78196 Reviewed by Ojan Vafai. * Configurations/FeatureDefines.xcconfig: 2012-02-10 Enrica Casucci Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies. https://bugs.webkit.org/show_bug.cgi?id=78282 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which now makes use of a new pasteboardStrategy object that is implemented both in WebKit and WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy interface but this one more step in the direction of removing access to NSPasteboard from the WebProcess. As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes. Reviewed by Anders Carlsson. * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy. * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface. (WebPlatformStrategies::createPasteboardStrategy): (WebPlatformStrategies::getTypes): (WebPlatformStrategies::bufferForType): (WebPlatformStrategies::getPathnamesForType): (WebPlatformStrategies::stringForType): (WebPlatformStrategies::copy): (WebPlatformStrategies::setTypes): (WebPlatformStrategies::setBufferForType): (WebPlatformStrategies::setPathnamesForType): (WebPlatformStrategies::setStringForType): 2012-02-10 Benjamin Poulain [Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT https://bugs.webkit.org/show_bug.cgi?id=78320 Reviewed by Joseph Pecoraro. * Configurations/WebKit.xcconfig: 2012-02-09 Alexey Proskuryakov REGRESSION (r104885): Articles not displayed in Vienna RSS reader https://bugs.webkit.org/show_bug.cgi?id=78280 Reviewed by Oliver Hunt. * Misc/WebNSURLExtras.h: * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]): Added a method to create a URL from a path, similarly to what KURL used to do. * WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Use it in an API where a known regression occurred. 2012-02-07 Antti Koivisto REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle] https://bugs.webkit.org/show_bug.cgi?id=78080 Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein. * WebView/WebFrame.mm: (-[WebFrame _typingStyle]): 2012-02-07 Tony Chang merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in https://bugs.webkit.org/show_bug.cgi?id=78036 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES. 2012-02-06 Anders Carlsson Overlay scrollbars flash when window is simply activated https://bugs.webkit.org/show_bug.cgi?id=77911 Reviewed by Kenneth Russell. * WebView/WebView.mm: (-[WebView _windowWillOrderOnScreen:]): (-[WebView _windowWillOrderOffScreen:]): Call FocusController::setContainingWindowIsVisible. 2012-02-06 Matthew Delaney toDataURL() uses stale data after putImageData() https://bugs.webkit.org/show_bug.cgi?id=65767 Reviewed by Chris Marrin. * WebCoreSupport/WebSystemInterface.mm: 2012-02-03 Antti Koivisto Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp https://bugs.webkit.org/show_bug.cgi?id=77779 Reviewed by Darin Adler. * WebView/WebHTMLView.mm: 2012-02-03 Antti Koivisto https://bugs.webkit.org/show_bug.cgi?id=77740 Split CSSMutableStyleDeclaration into separate internal and CSSOM types Reviewed by Andreas Kling and Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _typingStyle]): 2012-02-03 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=77691 Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use of device scale Reviewed by Andy Estes. toUserSpace() and toDeviceSpace() don't need to take device scale. Also restore a comment that I needlessly removed. * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): 2012-02-01 Dan Bernstein WebKit/mac part of Paginated display does not respect page-break-{before,after} https://bugs.webkit.org/show_bug.cgi?id=77505 Reviewed by Darin Adler. * WebView/WebView.mm: (-[WebView _setPaginationBehavesLikeColumns:]): Added this setter. (-[WebView _paginationBehavesLikeColumns]): Added this getter. * WebView/WebViewPrivate.h: 2012-01-25 Eric Seidel HTMLIsIndexElement should not expose HTMLInputElement properties https://bugs.webkit.org/show_bug.cgi?id=76095 Reviewed by Adam Barth. * MigrateHeaders.make: 2012-01-31 Pablo Flouret Fix compilation errors on build-webkit --debug --no-workers on mac. https://bugs.webkit.org/show_bug.cgi?id=75869 Reviewed by Adam Barth. * Workers/WebWorkersPrivate.mm: (+[WebWorkersPrivate workerThreadCount]): 2012-01-30 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=77263 PlatformScreenMac should not rely on NSWindow for important bits of data Reviewed by Geoff Garen. toUserSpace() and toDeviceSpace() now take a parameter for the deviceScaleFactor. * WebCoreSupport/WebChromeClient.mm: (windowScaleFactor): (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): 2012-01-25 Mark Rowe Build in to an alternate location when USE_STAGING_INSTALL_PATH is set. Adopt USE_STAGING_INSTALL_PATH Reviewed by David Kilzer. * Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name based on the normal framework location. This prevents an incorrect install name from being used when installing in to the staged frameworks directory. Look for our other frameworks in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of WebKit.framework. 2012-01-25 Eric Seidel HTMLIsIndexElement should not expose HTMLInputElement properties https://bugs.webkit.org/show_bug.cgi?id=76095 Reviewed by Adam Barth. * MigrateHeaders.make: 2012-01-25 Hajime Morita ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom https://bugs.webkit.org/show_bug.cgi?id=76863 Reviewed by Dimitri Glazkov. Added a feature flag. * Configurations/FeatureDefines.xcconfig: 2012-01-25 Enrica Casucci WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. https://bugs.webkit.org/show_bug.cgi?id=76951 Reviewed by Alexey Proskuryakov. * WebView/WebHTMLView.mm: Removed typingAttributes implementation. * WebView/WebView.mm: (-[WebView typingAttributes]): Added. 2012-01-24 Enrica Casucci WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. https://bugs.webkit.org/show_bug.cgi?id=76951 The Inspector bar calls the typingAttributes methods on the clients that support it to retrieve the set of attributes representing the style at the selection and uses this information to update the state of the B, I and U buttons. If this method is not supported, it defaults to the attributes of the previous character position, reporting an incorrect state. This occurs only when we have a caret selection. Reviewed by Alexey Proskuryakov. * WebView/WebHTMLView.mm: (-[WebHTMLView _styleForAttributeChange:]): Removed dead code. (-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore. (-[WebHTMLView typingAttributes]): Added. 2012-01-24 Benjamin Poulain pageCacheSupportsPlugins should default to true on WebKit1 https://bugs.webkit.org/show_bug.cgi?id=76891 Reviewed by Joseph Pecoraro. The default was left out of r102619 by accident. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): 2012-01-23 Geoffrey Garen JSValue::toString() should return a JSString* instead of a UString https://bugs.webkit.org/show_bug.cgi?id=76861 Reviewed by Gavin Barraclough. Mechanical changes to call value() after calling toString(), to convert from "JS string" (JSString*) to "C++ string" (UString), since toString() no longer returns a "C++ string". * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): * WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): 2012-01-20 Sam Weinig Make WebCore RunLoop work for WebKit1 https://bugs.webkit.org/show_bug.cgi?id=76739 Reviewed by Anders Carlsson. * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]): * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]): * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]): * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]): * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]): * Plugins/WebBaseNetscapePluginView.mm: * Plugins/WebBasePluginPackage.mm: * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]): * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]): * WebCoreSupport/WebFrameLoaderClient.mm: * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]): * WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]): * WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): (+[WebHTMLView initialize]): * WebView/WebResource.mm: (+[WebResourcePrivate initialize]): * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]): * WebView/WebView.mm: (+[WebView initialize]): * WebView/WebViewData.mm: (+[WebViewPrivate initialize]): Initialized the main run loop in addition to other initialization. 2012-01-20 Simon Fraser https://bugs.webkit.org/show_bug.cgi?id=76444 #if ENABLE(CSS_SHADERS) cannot appear in framework headers. This breaks builds. * WebView/WebPreferences.mm: * WebView/WebPreferencesPrivate.h: 2012-01-20 Alexandru Chiculita CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime https://bugs.webkit.org/show_bug.cgi?id=76444 Added private WebPreference property called "WebKitCSSCustomFilterEnabled". Reviewed by Nikolas Zimmermann. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences cssCustomFilterEnabled]): (-[WebPreferences setCSSCustomFilterEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-01-17 Enrica Casucci Missing NSForegroundColorAttributeName should be treated as black instead of transparent. https://bugs.webkit.org/show_bug.cgi?id=76490 Starting with Lion, there is no more NSForegroundColor attribute in the dictionary if the color matches the default (solid black). The fix consists in treating the lack of color as solid black instead of transparent as we did before. Added a TestWebKitAPI test. Reviewed by Darin Adler and Dan Bernstein. * WebView/WebHTMLView.mm: (-[WebHTMLView _styleForAttributeChange:]): 2012-01-17 Matthew Delaney On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier. Reviewed by Simon Fraser. * WebCoreSupport/WebSystemInterface.mm: Init newly added function. * WebView/WebHTMLView.mm: Added case for post-Lion builds that calls -setGeometryFlipped if the app is linked on or before Lion. 2012-01-17 Enrica Casucci REGRESSION (r101413): Correction panel overlaps misspelled text. https://bugs.webkit.org/show_bug.cgi?id=74589 When converting the rectangle from the root view, we need to take into account the height of the rectangle. Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _convertRectFromRootView:]): 2012-01-16 Simon Fraser ASSERTION FAILED: Uncaught exception - Cannot lock focus on image , because it is size zero loading techcrunch.com Reviewed by Anders Carlsson. Avoid trying to create image snapshots for zero-sized plugins, because it causes -[NSView lockFocus] to throw an exception. * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView cacheSnapshot]): 2012-01-16 Alexey Proskuryakov A follow-up fix for: A warning is logged to console when typing a bare "/" in Safari address bar https://bugs.webkit.org/show_bug.cgi?id=76236 Reviewed by John Sullivan. * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a path when there is a base URL. 2012-01-16 Jon Lee Build fix for r105086. * Configurations/FeatureDefines.xcconfig: 2012-01-12 Alexey Proskuryakov A warning is logged to console when typing a bare "/" in Safari address bar https://bugs.webkit.org/show_bug.cgi?id=76236 Reviewed by John Sullivan. * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths. 2012-01-16 Pablo Flouret Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac. https://bugs.webkit.org/show_bug.cgi?id=75865 Reviewed by Hajime Morita. * WebView/WebFrame.mm: (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]): 2012-01-15 Pablo Flouret Fix compilation errors on build-webkit --debug --no-video on mac. https://bugs.webkit.org/show_bug.cgi?id=75867 Reviewed by Philippe Normand. - WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded by VIDEO feature instead of FULLSCREEN_API. - _isAnyMoviePlaying implementation depends on VIDEO. * WebCoreSupport/WebChromeClient.h: * WebView/WebFullScreenController.mm: (-[WebFullScreenController _isAnyMoviePlaying]): 2012-01-11 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=75904 WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all the time -and corresponding- Reviewed by Darin Adler. New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we have one. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): When we know that mouse movements won't affect anything other than scrollbars, call our new function passMouseMovedEventToScrollbars(), otherwise we'll call the old mouseMoved(). (mouseEventIsPartOfClickOrDrag): (-[WebHTMLView _updateMouseoverWithEvent:]): Make sure not to remove the mouse observer when there are legacy scrollbars. (-[WebHTMLView removeMouseMovedObserver]): Set up a tracking area when the window is not key to ensure that the WebView gets the relevant events. Remove it when the window is key again so that we rely on the existing mechanism. (-[WebHTMLView windowDidBecomeKey:]): (-[WebHTMLView windowDidResignKey:]): 2012-01-10 Dan Bernstein Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver. Reviewed by Mark Rowe. * History/WebHistoryItem.mm: (-[WebHistoryItem copyWithZone:]): 2012-01-10 Chris Marrin Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work Unreviewed. * WebCoreSupport/WebChromeClient.h: 2012-01-10 Chris Marrin Turn off the FilterTrigger in WebKit and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=75914 Reviewed by Simon Fraser. Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger. * WebCoreSupport/WebChromeClient.h: (WebChromeClient::allowedCompositingTriggers): 2012-01-10 Dan Bernstein Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject() https://bugs.webkit.org/show_bug.cgi?id=75980 Reviewed by Mark Rowe. * History/WebHistoryItem.mm: (-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with -alloc, -initWithWebCoreHistoryItem:. 2012-01-06 Simon Fraser Mitigate scrollbar differences when running pixel tests https://bugs.webkit.org/show_bug.cgi?id=67217 Reviewed by Dan Bernstein. Make it possible to register a custom NSScroller class, which the WebDynamicScrollBarsView will use when mock scrollbars are enabled. Also ensure that the WebPreferences mock scrollbars preference is migrated into Settings. * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.mm: (+[WebDynamicScrollBarsView _horizontalScrollerClass]): (+[WebDynamicScrollBarsView _verticalScrollerClass]): (+[WebDynamicScrollBarsView setCustomScrollerClass:]): * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2012-01-05 Dan Bernstein Update copyright strings Reviewed by Mark Rowe. * Info.plist: 2012-01-05 Pratik Solanki WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions https://bugs.webkit.org/show_bug.cgi?id=75586 Reviewed by Alexey Proskuryakov. We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function, _userAgentString that returns a WTF::String to make this call faster. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::userAgent): * WebView/WebView.mm: (-[WebView _userAgentString]): (-[WebView userAgentForURL:]): * WebView/WebViewInternal.h: 2012-01-04 Anders Carlsson Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm https://bugs.webkit.org/show_bug.cgi?id=75447 Reviewed by Brian Weinstein. Resolve the ambiguity. * Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): 2012-01-04 Mihnea Ovidenie [Mac]Fix build after changeset 103997 https://bugs.webkit.org/show_bug.cgi?id=75530 Reviewed by Andreas Kling. * WebView/WebFrame.mm: * WebView/WebHTMLView.mm: * WebView/WebPDFView.mm: * WebView/WebView.mm: 2012-01-03 Jon Lee Leak of WebNotificationClient when page is destroyed https://bugs.webkit.org/show_bug.cgi?id=74980 Reviewed by Mark Rowe. * WebCoreSupport/WebNotificationClient.h: * WebCoreSupport/WebNotificationClient.mm: (WebNotificationClient::notificationControllerDestroyed): Remove the instance. 2012-01-02 Dan Bernstein [mac] Remove -[WebView setHoverFeedbackSuspended:] https://bugs.webkit.org/show_bug.cgi?id=75406 Reviewed by Tim Hatcher. * WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates. * WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged. * WebView/WebView.mm: (-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of Safari that call this. (-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support versions of Safari that call this. * WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar. * WebView/WebViewPrivate.h: Removed method definitions. 2011-12-31 Dan Bernstein WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer https://bugs.webkit.org/show_bug.cgi?id=75405 Reviewed by Anders Carlsson. Removed the WebKit/mac mechanism for dispatching fake mouse moved events when an HTML frame scrolls, since FrameView now does this. * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar. (-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to -_cancelUpdateMouseoverTimer. (-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer for dispatching a mouse moved event on scroll. (-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer. (-[WebHTMLView viewWillMoveToWindow:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. 2011-12-23 Ryosuke Niwa Chromium Mac build fix. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-12-21 Sam Weinig Start extracting platform specific bits out of PlatformEvents https://bugs.webkit.org/show_bug.cgi?id=75063 Reviewed by Anders Carlsson. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebView/WebFrame.mm: * WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (currentKeyboardEvent): (-[WebHTMLView flagsChanged:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): * WebView/WebView.mm: 2011-12-21 Timothy Hatcher Web Inspector: suppress incremental rendering and use application chrome mode https://webkit.org/b/75026 Reviewed by Joseph Pecoraro. * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting, set suppress incremental rendering and use application chrome mode. 2011-12-20 Pavel Feldman Web Inspector: reproducible crash after closing web inspector and browser window (iCab) https://bugs.webkit.org/show_bug.cgi?id=74255 Reviewed by Yury Semikhatsky. * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::bringFrontendToFront): (-[WebInspectorWindowController destroyInspectorView:]): 2011-12-19 Eric Carlson Enable for Mac build https://bugs.webkit.org/show_bug.cgi?id=74838 Reviewed by Darin Adler. * Configurations/FeatureDefines.xcconfig: 2011-12-16 Ryosuke Niwa Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step https://bugs.webkit.org/show_bug.cgi?id=74748 Reviewed by Eric Seidel. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::registerUndoOrRedoStep): (WebEditorClient::registerUndoStep): (WebEditorClient::registerRedoStep): 2011-12-16 Sam Weinig Give PlatformEvents a base class https://bugs.webkit.org/show_bug.cgi?id=74685 Reviewed by Anders Carlsson. Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent and PlatformGestureEvent and move Type enumeration and modifiers down to it. * WebView/WebFrame.mm: (-[WebFrame _dragSourceEndedAt:operation:]): * WebView/WebHTMLView.mm: (currentKeyboardEvent): (-[WebHTMLView _interpretKeyEvent:savingCommands:]): * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): 2011-12-16 Simon Fraser Fix a #elsif fumble in my earlier commit. * WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]): 2011-12-16 Ryosuke Niwa Only EditCommandComposition should implement unapply and reapply https://bugs.webkit.org/show_bug.cgi?id=74490 Reviewed by Eric Seidel. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (-[WebUndoStep initWithUndoStep:]): (-[WebUndoStep dealloc]): (+[WebUndoStep stepWithUndoStep:]): (-[WebUndoStep step]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): 2011-12-16 Simon Fraser Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer Reviewed by Sam Weinig. Now that we're using a flipped view to host the compositing layers, we should not set geometryFlipped on the root layer ourselves. * WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]): 2011-12-16 Mark Hahnenberg De-virtualize destructors https://bugs.webkit.org/show_bug.cgi?id=74331 Reviewed by Geoffrey Garen. * Plugins/Hosted/ProxyRuntimeObject.h: Remove empty virtual destructor. * Plugins/Hosted/ProxyRuntimeObject.mm: 2011-12-14 Ryosuke Niwa Mac build fix after r102874. * WebCoreSupport/WebChromeClient.mm: 2011-12-14 Jing Zhao Opening two popup menus by dispatchEvent() makes problems. https://bugs.webkit.org/show_bug.cgi?id=73304 Reviewed by Kent Tamura. * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup(). * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::hasOpenedPopup): Not implemented. 2011-12-14 Michael Saboff Mac WebScriptDebugger crashes beneath sourceParsed() https://bugs.webkit.org/show_bug.cgi?id=74564 Reviewed by Gavin Barraclough. * WebView/WebScriptDebugger.mm: (toNSString): Change to use ->characters() method to actually get characters for string conversion. 2011-12-14 Hajime Morrita JS_INLINE and WTF_INLINE should be visible from WebCore https://bugs.webkit.org/show_bug.cgi?id=73191 Reviewed by Kevin Ollivier. Removed macro definitions which is now provided by Platform.h * WebKitPrefix.h: 2011-12-13 Jon Lee Enable notifications on Mac. Reviewed by Sam Weinig. * Configurations/FeatureDefines.xcconfig: 2011-12-12 Ryosuke Niwa WebKit code shouldn't be calling applyCommand directly https://bugs.webkit.org/show_bug.cgi?id=74337 Reviewed by Darin Adler. * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): 2011-12-12 Brady Eidson Page cache should support pages with plugins. and https://bugs.webkit.org/show_bug.cgi?id=13634 Expose a WebKit preference for the page cache supporting plugins (on by default). Reviewed by Anders Carlsson. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences pageCacheSupportsPlugins]): (-[WebPreferences setPageCacheSupportsPlugins:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): 2011-12-12 Dan Bernstein Text highlight changes to gray selection color when menu extra is shown Reviewed by John Sullivan. * WebView/WebView.mm: (-[WebView _updateActiveState]): Changed to use -[NSWindow _hasKeyAppearance] instead of -isKeyWindow. The former also returns YES when a menu extra is open. (-[WebView addWindowObserversForWindow:]): Removed code to observe NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification. (-[WebView removeWindowObservers]): Removed code to stop observing the above. (-[WebView _windowChangedKeyState]): Overridden this to call _updateActiveState. This is called when the result of -_hasKeyAppearance changes. (-[WebView _windowWillOrderOnScreen:]): Removed call to _updateActiveState, previously needed for popovers, because _windowChangedKeyState is invoked at the right time for them. (-[WebView _windowWillOrderOffScreen:]): Ditto. 2011-12-07 Mark Rowe Fix the 32-bit build. Ignore some warnings that only occur in 32-bit. * Plugins/WebNetscapePluginPackage.mm: 2011-12-07 Mary Wu Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline https://bugs.webkit.org/show_bug.cgi?id=73986 Reviewed by Kenneth Rohde Christiansen. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): 2011-12-06 Alexey Proskuryakov REGRESSION (WebKit2): Kill ring is not cleared when selection changes https://bugs.webkit.org/show_bug.cgi?id=73888 Reviewed by Mark Rowe. * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Added a FIXME comment. (-[WebHTMLView _selectionChanged]): Moved the code to clear kill ring to WebCore. The rest of kill ring implementation is there, so it makes no sense to have this call in WebKits. 2011-12-05 Anders Carlsson Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not https://bugs.webkit.org/show_bug.cgi?id=73862 Reviewed by Andy Estes. Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases where we don't want the layer flush scheduler to be invalidated. * WebView/WebView.mm: (LayerFlushController::flushLayers): * WebView/WebViewData.h: 2011-12-05 Eric Carlson Add WebKit preferences for text track settings https://bugs.webkit.org/show_bug.cgi?id=73721 Reviewed by John Sullivan. * WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions, and shouldDisplayTextDescriptions properties. * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize new preferences to NO. (-[WebPreferences setShouldDisplaySubtitles:]): Added. (-[WebPreferences shouldDisplaySubtitles]): Ditto. (-[WebPreferences setShouldDisplayCaptions:]): Ditto. (-[WebPreferences shouldDisplayCaptions]): Ditto. (-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto. (-[WebPreferences shouldDisplayTextDescriptions]): Ditto. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs. 2011-12-03 Dan Bernstein Crash at WebCore::SubresourceLoader::releaseResources Reviewed by Darin Adler. * WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into a WebCFAutorelease(self). This prevents re-entry into this method due to the WebView closing and canceling all subresource loads, including the one we have just removed. 2011-12-02 David Levin Rename WTF class from TemporarilyChange to TemporaryChange. https://bugs.webkit.org/show_bug.cgi?id=73479 Reviewed by Eric Seidel. * ForwardingHeaders/wtf/TemporarilyChange.h: Removed. * ForwardingHeaders/wtf/TemporaryChange.h: Added. 2011-12-02 Simon Fraser Layers are flipped in WebKit1 views Reviewed by Sam Weinig. Host the compositing layers in an NSView which is flipped, which helps AppKit get the geometry right in some situations. * WebView/WebHTMLView.mm: (-[WebLayerHostingFlippedView isFlipped]): (-[WebHTMLView attachRootLayer:]): 2011-12-02 Hajime Morrita Unreviewed, rolling out r101751 and r101775. http://trac.webkit.org/changeset/101751 http://trac.webkit.org/changeset/101775 https://bugs.webkit.org/show_bug.cgi?id=73191 breaks Windows build * WebKitPrefix.h: 2011-12-01 Hajime Morrita JS_INLINE and WTF_INLINE should be visible from WebCore https://bugs.webkit.org/show_bug.cgi?id=73191 Reviewed by Kevin Ollivier. Removed macro definitions which is now provided by Platform.h * WebKitPrefix.h: 2011-11-30 Alexey Proskuryakov Remove an unneeded argument from FrameLoaderClient::download https://bugs.webkit.org/show_bug.cgi?id=73486 Reviewed by Andreas Kling. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Updated for the change. 2011-11-30 Dan Bernstein WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view https://bugs.webkit.org/show_bug.cgi?id=73476 Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _setPageLength:]): Added this accessor. (-[WebView _pageLength]): Ditto. * WebView/WebViewPrivate.h: 2011-11-30 Alexey Proskuryakov Download page URL should be set by WebCore https://bugs.webkit.org/show_bug.cgi?id=73358 Reviewed by Darin Adler. * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now in WebCore. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): There is no need to set original URL post factum any more. (WebFrameLoaderClient::startDownload): Ditto. 2011-11-29 David Levin Add a way to revert a variable to its previous value after leaving a scope. https://bugs.webkit.org/show_bug.cgi?id=73371 Reviewed by Adam Barth. * ForwardingHeaders/wtf/TemporarilyChange.h: Added. 2011-11-29 Jessie Berlin WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins the first time it is called. https://bugs.webkit.org/show_bug.cgi?id=73374 () Reviewed by Brady Eidson. * Storage/WebStorageTrackerClient.h: * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::didFinishLoadingOrigins): 2011-11-15 Anders Carlsson DragClient::dragSourceActionMaskForPoint should use root view coordinates https://bugs.webkit.org/show_bug.cgi?id=72409 Reviewed by Sam Weinig. * WebCoreSupport/WebDragClient.mm: (WebDragClient::dragSourceActionMaskForPoint): Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system. 2011-11-15 Anders Carlsson EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates https://bugs.webkit.org/show_bug.cgi?id=72408 Reviewed by Sam Weinig. * WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::show): Convert the bounding rect to web view coordinates. * WebView/WebView.mm: (-[WebView _convertPointFromRootView:]): (-[WebView _convertRectFromRootView:]): * WebView/WebViewInternal.h: Add helper methods for converting from root view coordinates to web view coordinates. 2011-11-29 Roland Steiner