2011-02-16 Aparna Nandyal Reviewed by Andreas Kling. [Qt] QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments https://bugs.webkit.org/show_bug.cgi?id=29424 ensureAbsoluteUrl function was stripping the query and the fragment part of the url. Corrected this. * Api/qwebframe.cpp: (ensureAbsoluteUrl): 2011-02-15 Csaba Osztrogonác Unreviewed. [Qt][V8] Buildfix. Add missing USE(JSC) guard. * Api/qwebelement.cpp: 2011-02-15 Kenneth Russell Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::defaultMinimumTimerInterval): (DumpRenderTreeSupportQt::setMinimumTimerInterval): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-01-26 MORITA Hajime Reviewed by Ryosuke Niwa. Refactoring: Extract TextCheckerClient from EditorClient https://bugs.webkit.org/show_bug.cgi?id=53213 * WebCoreSupport/EditorClientQt.h: (WebCore::EditorClientQt::textChecker): 2011-02-07 Ryosuke Niwa Reviewed by Adam Barth. Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard https://bugs.webkit.org/show_bug.cgi?id=52417 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently not implemented. * WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::canCopyCut): Added. (WebCore::EditorClientQt::canPaste): Added. * WebCoreSupport/EditorClientQt.h: 2011-02-14 Alexis Menard Reviewed by Andreas Kling. [Qt] Crash on application exit after constructing and destroying a QWebView twice https://bugs.webkit.org/show_bug.cgi?id=54000 Test case to cover the crash. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::deleteQWebViewTwice): 2011-02-11 Viatcheslav Ostapenko Reviewed by Tor Arne Vestbø. [Qt] wmode gets overridden even if already windowless in QGraphicsWebView Do not override wmode if it is not set to "window". https://bugs.webkit.org/show_bug.cgi?id=50495 * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): 2011-02-10 Nate Chapin Reviewed by Adam Barth. Update calls to DocumentWriter. https://bugs.webkit.org/show_bug.cgi?id=50489 * Api/qwebframe.cpp: (QWebFrame::setUrl): * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Ensure WebView press delay timer is cancelled when grab is taken https://bugs.webkit.org/show_bug.cgi?id=54242 As reported in: http://bugreports.qt.nokia.com/browse/QTBUG-15529 Flickable steals the grab, but the timer was not stopped and the keepGrab flag is set and the mouse grabbed. This means that the WebView now has the grab and subsequent clicks on another element are ignored. Original patch from Martin Jones reviewed (there) by Joona Petrell 52068f57f9c32098a90cc217730a530f85590f65 * declarative/qdeclarativewebview.cpp: (GraphicsWebView::sceneEvent): * declarative/qdeclarativewebview_p.h: 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Fix assert in QDeclarativeWebView https://bugs.webkit.org/show_bug.cgi?id=54240 As reported in: http://bugreports.qt.nokia.com/browse/QTBUG-14278 Instantiating a QDeclarativeWebView twice will trigger an assertion when in debug mode. Original patch from Thomas Hartmann , reviewed (there) by Aaron Kennedy f532679ca11914b453e22342f2ae5e9f790ce47a * declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init): 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Misc documentation fixes/updates https://bugs.webkit.org/show_bug.cgi?id=54236 There are a few commits in the Qt repository (master and 4.7 branches) with QtWebKit documentation fixes: 84d278501a19eaccf9a77cccd95ca5d17a2dcd2b Clarified documentation of loadFinished() signal eebe205b306daaa3674d9746de11a73bef4bd0de Doc: Fixed QML, unindented snippet b0d64717d2c541976dc5524e4100c62f060e206f doc: Changed a table into 3 tables to eliminate a \raw. As these are all minor doc changes, I decided to group them into one single patch. * Api/qwebpage.cpp: * declarative/qdeclarativewebview.cpp: * docs/qtwebkit.qdoc: 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Remove the use of deprecated qVariant* https://bugs.webkit.org/show_bug.cgi?id=54229 This was applied on the Qt repository and affects QtWebKit there. (633f3f45e5420663cf4ceadea79e62fea44cd2eb) The side effect of this change is that we won't be able to build QtWebKit with MSVC 6, as it doesn't support member template functions (not sure if it's possible today anyway). Original patch from Olivier Goffart , with review reported as being from the mailing list. The changes are result of the following commands: git grep -O"sed -i 's/qVariantValue]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect): * tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myInvokableWithQObjectListArg): (MyQObject::myInvokableWithListOfIntArg): (MyQObject::myInvokableWithQObjectStarArg): (MyQObject::myInvokableWithQBrushArg): (MyQObject::myInvokableWithBrushStyleArg): (MyQObject::myInvokableWithVoidStarArg): (MyQObject::myInvokableWithAmbiguousArg): (MyQObject::myInvokableWithDefaultArgs): (MyQObject::myInvokableWithPointArg): (MyQObject::myOverloadedSlot): 2011-02-10 Robert Hogan Reviewed by Laszlo Gombos. [Qt] Return menu items from eventSender.contextMenu() https://bugs.webkit.org/show_bug.cgi?id=53039 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (iterateContextMenu): (DumpRenderTreeSupportQt::contextMenu): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-02-10 Alexis Menard Reviewed by Andreas Kling. [Qt] In trunk with Qt Multimedia the full screen mode doesn't work. https://bugs.webkit.org/show_bug.cgi?id=54201 Add a default fullscreen handler when there is no plaftform plugin installed. This handler creates a fullscreen QVideoWidget and plays the video. Space pause/resume the video playback and esc quit the fullscreen mode. * WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback): (WebCore::DefaultFullScreenVideoHandler::enterFullScreen): (WebCore::DefaultFullScreenVideoHandler::exitFullScreen): (WebCore::FullScreenVideoQt::FullScreenVideoQt): * WebCoreSupport/FullScreenVideoQt.h: * WebCoreSupport/FullScreenVideoWidget.cpp: Added. (WebCore::FullScreenVideoWidget::FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::~FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::show): (WebCore::FullScreenVideoWidget::closeEvent): (WebCore::FullScreenVideoWidget::event): (WebCore::FullScreenVideoWidget::keyPressEvent): (WebCore::FullScreenVideoWidget::hideCursor): (WebCore::FullScreenVideoWidget::showCursor): * WebCoreSupport/FullScreenVideoWidget.h: Added. 2011-02-10 kasthuri Reviewed by Antonio Gomes. [Qt] QWebFrame::setHtml doesn't emit loadFinished signal https://bugs.webkit.org/show_bug.cgi?id=38634 QWebView->page()->mainFrame()->setHtml(html) is always emitting the loadFinished() signal for all types of html files. But the proposed test content was trying to catch the signal after calling setHtml() api and becuase of this the emitted signal for a simple html page is never caught as its emitted before even the connect call was successful. updated the tst_QWebFrame::setHtml() in tst_qwebframe.cpp to check for signal using the QSignalSpy. * tests/qwebframe/tst_qwebframe.cpp: 2011-02-09 Robert Hogan Reviewed by Csaba Osztrogonác. [Qt] REGRESSION (r73535): tst_QWebPage fails https://bugs.webkit.org/show_bug.cgi?id=51331 Since r73535 a ContextMenu is only created when a context menu event is received, so QWebPage::updatePositionDependentActions() can't depend on one being there if it is called directly by the client. QtWebKit itself only ever calls updatePositionDependentActions() when a context menu event has been received. Update tst_QWebPage:contextMenuCrash to create a context menu. Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash. There doesn't seem to be a good reason for creating a context menu if clients call QWebPage::updatePositionDependentActions() when no context menu event has ever been received. * Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu): * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCrash): 2011-02-09 Robert Hogan Reviewed by Antonio Gomes. [Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode https://bugs.webkit.org/show_bug.cgi?id=53921 QDRTNode needs a copy constructor and an operator= in order to keep proper refcounts. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (:m_node): (QDRTNode::operator=): (DumpRenderTreeSupportQt::nodesFromRect): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-02-08 Adam Barth Reviewed by Eric Seidel. Remove orphan code from old parser https://bugs.webkit.org/show_bug.cgi?id=53984 * WebCoreSupport/ChromeClientQt.h: 2011-02-07 Aparna Nandyal Reviewed by Andreas Kling. [Qt] - Context menu needs "Copy" as well when the selected text is a link. https://bugs.webkit.org/show_bug.cgi?id=40983 Added a test case to create a context sensitive menu. A check is made if it has Copy menu item when user selects a link and opens context menu. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy): 2011-02-07 Benjamin Poulain Reviewed by Kenneth Rohde Christiansen. [Qt] cookiesEnabled could create the cookieJar on the wrong thread. https://bugs.webkit.org/show_bug.cgi?id=52289 Test if the cookie jar is created in the right thread when accessed from the navigator object. * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread): 2011-02-07 Qi Zhang Reviewed by Andreas Kling. [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl https://bugs.webkit.org/show_bug.cgi?id=52974 Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction. * Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action): * Api/qwebpage.h: * WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard): * WebCoreSupport/WebPlatformStrategies.h: 2011-02-07 Enrica Casucci Reviewed Adam Roben and Darin Adler. WebKit2: drag and drop support on Windows. https://bugs.webkit.org/show_bug.cgi?id=52775 Removed createDragImageForLink from DragClient. * WebCoreSupport/DragClientQt.cpp: * WebCoreSupport/DragClientQt.h: 2011-02-06 Robert Hogan Reviewed by Andreas Kling. [Qt] Remove unnecessary QRect assignment https://bugs.webkit.org/show_bug.cgi?id=53873 * Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords): 2011-02-06 Robert Hogan Reviewed by Andreas Kling. [Qt] Clear page's groupName even when not in DRT https://bugs.webkit.org/show_bug.cgi?id=53874 Matches behaviour of other ports. * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon): 2011-02-03 Yury Semikhatsky Reviewed by Pavel Feldman. Web Inspector: remove settings related methods from InspectorClient https://bugs.webkit.org/show_bug.cgi?id=53686 * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt): * WebCoreSupport/InspectorClientQt.h: 2011-02-03 Adam Langley Reviewed by Adam Barth. Plumb mixed script URL to FrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=52384 Regressions covered by http/tests/security/mixedContent/* * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didRunInsecureContent): * WebCoreSupport/FrameLoaderClientQt.h: 2011-02-01 Csaba Osztrogonác Unreviewed Qt buildfix after r77286. https://bugs.webkit.org/show_bug.cgi?id=53520 Remove the physical terminology from IntRect and FloatRect. * WebCoreSupport/PopupMenuQt.cpp: (WebCore::PopupMenuQt::show): 2011-01-31 No'am Rosenthal Reviewed by Kenneth Rohde Christiansen. [Qt] QWebElements example from QtWebKit Bridge documentation does not work at all https://bugs.webkit.org/show_bug.cgi?id=46748 Problem was that we need to register QWebElement's variant-type to Qt's meta type system at some point. This wasn't caught by previous tests inside tst_QWebFrame because it only appears when there's also a QWebElement property. Added a regression test to tst_QWebFrame. * tests/qwebframe/tst_qwebframe.cpp: (MyWebElementSlotOnlyObject::doSomethingWithWebElement): (MyWebElementSlotOnlyObject::tagName): 2011-01-31 Srikumar Bonda Reviewed by Andreas Kling. [Qt] ContextMenuClientQt.cpp has coding-style errors "RefCounted.h" header inclusion style changed to https://bugs.webkit.org/show_bug.cgi?id=40243 * WebCoreSupport/ContextMenuClientQt.cpp: 2011-01-28 Dan Bernstein Reviewed by Sam Weinig. and