2009-10-30 Mark Rowe Merge r50354. 2009-10-29 Jon Honeycutt MSAA: Accessibility of headings is not correct https://bugs.webkit.org/show_bug.cgi?id=30937 Reviewed by Alice Liu. * AccessibleBase.cpp: (AccessibleBase::get_accDescription): Call the object's descriptionForMSAA(). Moved the comment to the WebCore file. (AccessibleBase::get_accRole): If the object has a string role, return that. Otherwise, return the integer role. * AccessibleBase.h: Removed description(), as this was moved to WebCore. 2009-10-30 Mark Rowe Merge r50353. 2009-10-29 Jon Honeycutt MSAA: Accessibility of links is wrong https://bugs.webkit.org/show_bug.cgi?id=30928 Reviewed by Darin Adler. * AccessibleBase.cpp: (AccessibleBase::get_accState): Check whether the element is linked, instead of whether the node is an anchor, so the child "linkable" elements of anchor elements will also be "linked". (AccessibleBase::name): Return the name for MSAA. (AccessibleBase::value): Return the string value for MSAA. 2009-10-23 Mark Rowe Merge r50019. Build fix. Include config.h before including other files. * AccessibleImage.cpp: 2009-10-23 Mark Rowe Merge r50004. 2009-10-23 Jon Honeycutt MSAA: Name for image elements should use alt attribute text https://bugs.webkit.org/show_bug.cgi?id=30727 Reviewed by Alice Liu. * AccessibleBase.cpp: (AccessibleBase::createInstance): If the AccessibilityObject is an image, return an AccessibleImage. * AccessibleImage.cpp: Added. (AccessibleImage::AccessibleImage): Call the base constructor. (AccessibleImage::name): If the object is not an AccessibilityRenderObject, return the base's name(). Look first for an ARIA "labeled-by" attribute, then look for an alternate text attribute. Fall back to the base's name(). * AccessibleImage.h: Added. (AccessibleImage::~AccessibleImage): * WebKit.vcproj/WebKit.vcproj: Add AccessibleImage to the project. 2009-10-13 Mark Rowe Merge r48770. 2009-09-25 Darin Adler Reviewed by Steve Falkenburg. Speed up access to history items by caching date computation. * History/WebHistory.mm: (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay. Returns the beginning of the day that the passed time is within and the beginning of the next day. (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for multiple dates within the same day, which is the common case. (dateKey): Added. Calls beginningOfDay and converts to an integer. (WebHistory::findKey): Changed to call dateKey instead of timeIntervalForBeginningOfDay. 2009-10-13 Mark Rowe Merge r48324. 2009-09-11 Steve Falkenburg Reviewed by Dan Bernstein. Properly propagate preference from WebPreferences to WebCore::Settings. https://bugs.webkit.org/show_bug.cgi?id=29192 * WebView.cpp: (WebView::initWithFrame): Apply setting when creating a new WebView. (WebView::notifyPreferencesChanged): Apply setting when preferences change. 2009-10-13 Mark Rowe Merge r48308. 2009-09-11 Steve Falkenburg Reviewed by Darin Adler. Allow WebKit clients to opt out of high resolution timers on Windows. https://bugs.webkit.org/show_bug.cgi?id=29192 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter. Put this just after last 4.0.3 method for future merging. * Interfaces/WebKit.idl: Touched to force a rebuild. * WebPreferenceKeysPrivate.h: Added prefs key for high res timers. * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled. (WebPreferences::setShouldUseHighResolutionTimers): Added. (WebPreferences::shouldUseHighResolutionTimers): Added. * WebPreferences.h: Added getter/setter. 2009-10-13 Mark Rowe Merge r49026. 2009-10-02 Steve Falkenburg Reviewed by Mark Rowe. Safari version number shouldn't be exposed in WebKit code For a WebKit version of 532.3.4: Product version is: 5.32.3.4 (was 4.0.3.0) File version is: 5.32.3.4 (was 4.532.3.4) * WebKit.vcproj/WebKit.rc: 2009-10-12 Mark Rowe Merge r48946. 2009-09-30 Sam Weinig Reviewed by Dan Bernstein. Fix for Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window * Interfaces/IWebFramePrivate.idl: * WebFrame.cpp: (WebFrame::allowsFollowingLink): * WebFrame.h: 2009-08-17 Steve Falkenburg Merge r47311. 2009-08-13 Jon Honeycutt Part of No MSAA focus events fired for Webkit nightly (20866) https://bugs.webkit.org/show_bug.cgi?id=20866 Reviewed by Oliver Hunt. * AccessibleBase.cpp: (AccessibleBase::getAccessibilityObjectForChild): If the child ID is negative, negate it and treat it as an AXID. 2009-08-05 Mark Rowe Merge r46638. 2009-07-31 Anders Carlsson Reviewed by Dan Bernstein. -Fix Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count. * WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create): * WebCoreSupport/EmbeddedWidget.h: 2009-07-15 Steve Falkenburg Merge r45892. 2009-07-14 Steve Falkenburg Reorganize JavaScriptCore headers into: API: include/JavaScriptCore/ Private: include/private/JavaScriptCore/ Reviewed by Darin Adler. * WebKit.vcproj/WebKit.vcproj: 2009-07-11 Mark Rowe Disable channel messaging * WebKit.vcproj/WebKit.vcproj: 2009-07-11 Mark Rowe Disable datagrid * WebKit.vcproj/WebKit.vcproj: 2009-07-09 Drew Wilson Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=26903 Turned on CHANNEL_MESSAGING by default because the MessageChannel API can now be implemented for Web Workers and is reasonably stable. * WebKit.vcproj/WebKit.vcproj: 2009-07-09 Brian Weinstein Reviewed by Alice Liu. Fix of Add preferences key to remember if the Inspector was docked (14271) https://bugs.webkit.org/show_bug.cgi?id=27140 Added a preference key to remember whether the user prefers the inspector detached or attached. * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible (WebInspectorClient::closeWindow): Ditto (WebInspectorClient::attachWindow): Set preference to attached windows here (WebInspectorClient::detachWindow): Set preference to detached windows here (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached (WebInspectorClient::onClose): Pass both parameters into setWindowVisible 2009-07-09 Alexey Proskuryakov Reviewed by Oliver Hunt. Visit count shouldn't be incremented by redirects. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Do not increase visit count if there is a redirect source. As a result, only pages that were explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking a link) will be counted. * Interfaces/IWebHistoryItemPrivate.idl: * WebHistory.cpp: (WebHistory::visitedURL): * WebHistory.h: * WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle): * WebHistoryItem.h: Marshal this new argument all the way down to WebCore. 2009-07-09 Beth Dakin and Jon Honeycutt Reviewed by Dave Hyatt. Make Widget RefCounted to fix: REGRESSION (TOT): In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after clicking To Do's close box WER #16: Repro Access Violation in WebCore::PluginView::bindingInstance (1310178023) -and- WER #13: Crash in WebKit! WebCore::PluginView::performRequest+203 (1311461169) * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): * WebCoreSupport/WebFrameLoaderClient.h: * WebFrame.cpp: (WebFrame::createJavaAppletWidget): * WebFrame.h: 2009-07-09 Sam Weinig Reviewed by Steve Falkenburg. Roll out r43848. The quirk is no longer necessary. * WebView.cpp: (WebView::userAgentForKURL): 2009-07-07 Ada Chan Reviewed by Dave Hyatt. Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView. https://bugs.webkit.org/show_bug.cgi?id=27057 * WebView.cpp: (WebViewWndProc): 2009-07-02 Erik Arvidsson Reviewed by Adam Roben. [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc https://bugs.webkit.org/show_bug.cgi?id=26699 * WebDropSource.cpp: (WebDropSource::QueryContinueDrag): 2009-07-02 Oliver Hunt Reviewed by Anders Carlsson. REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670) Make windows loader client match mac behaviour more closely. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::forceLayout): 2009-06-30 Brent Fulgham Reviewed by Adam Roben. Build DumpRenderTree under Cairo. https://bugs.webkit.org/show_bug.cgi?id=26457 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the DumpRenderTree build, and use the in the Debug_Cairo and Release_Cairo targets. 2009-07-02 Eric Carlson Fix Windows build by including missing localized string methods. * WebCoreLocalizedStrings.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText): 2009-07-01 David Hyatt Reviewed by Tim Hatcher. REGRESSION (r44474): Form text field has focus ring, looks focused, even though the field is not actually focused for keyboard input Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't have focus. * WebView.cpp: (WebViewWndProc): 2009-06-29 David Hyatt Fix Windows bustage. Missed two configurations for enabling DATAGRID. * WebKit.vcproj/WebKit.vcproj: 2009-06-29 Jessie Berlin Reviewed by Adam Roben. Fix the windows build. * WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::isSpeaking): * WebCoreSupport/WebContextMenuClient.h: 2009-06-29 David Hyatt Reviewed by Adam Roben. Make sure to patch all configurations to have datagrid enabled. * WebKit.vcproj/WebKit.vcproj: 2009-06-29 David Hyatt Reviewed by Adam Roben. Put behind an ifdef. * WebKit.vcproj/WebKit.vcproj: 2009-06-26 Brian Weinstein Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=26695 Added hit testing on scrollbars, so if you start a gesture over a scrollbar, it isn't counted, and lets the user drag the scrollbar itself instead of a panning gesture. Also cleaned up code in gesture. * WebView.cpp: (WebView::gestureNotify): (WebView::gesture): 2009-06-26 Jeremy Orlow Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=26767 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp despite it being deleted from the repo by the following patch/commit: https://bugs.webkit.org/show_bug.cgi?id=26732 http://trac.webkit.org/changeset/45290 * WebKitDLL.cpp: 2009-06-26 Yongjun Zhang Reviewed by Eric Seidel. Bug 20303: [Qt] Key events are not working in frames. Move the scroll handling code to EventHandler so that other ports can share the functionality. * WebView.cpp: (WebView::keyDown): (EnumTextMatches::QueryInterface): 2009-06-23 Anders Carlsson Reviewed by Darin Adler. WebKit side of . * Interfaces/IWebUIDelegate.idl: Add a newPasteboard out parameter to willPerformDragSourceAction. * WebCoreSupport/WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): Implement this. If the client returns a new pasteboard, use it for the drag. * WebCoreSupport/WebInspectorDelegate.h: (WebInspectorDelegate::willPerformDragSourceAction): Add the new parameter. 2009-06-20 Darin Adler Reviewed by Sam Weinig. Need more processing of pluginspage. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. 2009-06-19 Kenneth Rohde Christiansen Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=26494 Bug 26494: RenderTheme::themeForPage reads from Settings before it has been initialized by WebKit Get the shouldPaintNativeControls preference and update the settings before initializing the page, as the page depends on it after the themeForPage change. * WebView.cpp: (WebView::initWithFrame): 2009-06-19 Brian Weinstein Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=26488 No Support for Single Finger or Two Finger Panning in Windows 7 Added the code necessary for single finger and two-finger panning with window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages, and interpret the panning command. Also, added WindowsTouch.h which contains structs and #defines from the Windows 7 SDK. * WebKit.vcproj/WebKit.vcproj: * WebView.cpp: (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar (WebView::gesture): Handles the Panning gesture, creating the WheelEvent (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY * WebView.h: * WindowsTouch.h: Added. 2009-06-18 Adam Barth Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=26199 Added preference to enable the XSSAuditor. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): 2009-06-18 Brent Fulgham Reviewed by Dave Levin. Remove some boilerplate using the BitmapInfo struct. https://bugs.webkit.org/show_bug.cgi?id=26425 * WebFrame.cpp: (WebFrame::spoolPages): * WebIconDatabase.cpp: (createDIB): * WebKit.vcproj/WebKit.sln: * WebNodeHighlight.cpp: (WebNodeHighlight::update): * WebView.cpp: (WebView::ensureBackingStore): 2009-06-17 Steve Falkenburg Consolidate WebKit COM interfaces. Moved IID from the highest numbered COM interface to the first interface and combined all methods. Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces. Reviewed by Adam Roben. * Interfaces/IWebFrameLoadDelegate.idl: * Interfaces/IWebFrameLoadDelegatePrivate.idl: * Interfaces/IWebResourceLoadDelegatePrivate.idl: * Interfaces/IWebUIDelegate.idl: * Interfaces/IWebUIDelegatePrivate.idl: * Interfaces/WebKit.idl: * WebCoreSupport/WebChromeClient.cpp: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebContextMenuClient.cpp: * WebCoreSupport/WebFrameLoaderClient.cpp: * WebCoreSupport/WebInspectorDelegate.h: * WebFrame.cpp: * WebView.cpp: 2009-06-16 Kenneth Rohde Christiansen Reviewed by Adam Roben. Create a different RenderTheme per page, so that RenderTheme has access to page specific theming. This is needed for the Qt port, as Qt supports setting the theme (style) per widget. This change was suggested and discussed with Dave Hyatt. More detailed: 1) Create a theme per page or one global one, depending on the needs of the platform. 2) Add an accesser to the theme from RenderObject. 3) Change all uses of the theming to access the theme through RenderObject, using the global default theme as fallback, when the document of RenderObject has no page. When we don't have access to a RenderObject, use the default theme. 4) Modify all RenderTheme platform implementations to work with the above changes, still creating only one global theme. * WebView.cpp: (WebViewWndProc): Get the theme from the associated page. 2009-06-16 Brian Weinstein Reviewed by Adam Roben. Switch Control+Mousewheel Zooming definitions to match other browsers on Windows. Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in. https://bugs.webkit.org/show_bug.cgi?id=25875. * WebView.cpp: (WebView::mouseWheel): 2009-06-16 Brent Fulgham Reviewed by Darin Adler. Use consistent Windows GUID Comparison Functions. https://bugs.webkit.org/show_bug.cgi?id=26427. * WebView.cpp: (EnumTextMatches::QueryInterface): == Rolled over to ChangeLog-2009-06-16 ==