2014-03-26 Matthew Hanson Remove extraneous ! from merge of r166304. 2014-03-26 Matthew Hanson Merge r166304. 2014-03-26 Jer Noble REGRESSION(r162679): Poster image visible under the video https://bugs.webkit.org/show_bug.cgi?id=130783 Reviewed by Simon Fraser. In the listed revision, we started checking for isRenderImage() instead of isImage(). RenderMedias return 'true' for the first but 'false' for the second. Change the if() statement to check for isRenderMedia() in addition to !isRenderImage(). * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): 2014-03-24 Matthew Hanson Remove a commented line of code introduced by r166104. Reviewed by Babak Shafiei. A line was commented out when it should have been deleted. This patch corrects that oversight. * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): 2014-03-22 Matthew Hanson Finish merge of r160065. The changes from Source/WebCore/rendering/RenderView.cpp were incorrectly omitted from the original merge in r165142. 2013-12-03 Ryosuke Niwa Potential crash in RenderView::selectionBounds and RenderView::repaintSelection https://bugs.webkit.org/show_bug.cgi?id=125207 Reviewed by Simon Fraser. Merge https://chromium.googlesource.com/chromium/blink/+/f9e6e288a5aa959f05c374806121aaf0fc52d440 Update style in FrameSelection instead of RenderView's member functions. These are the last two member functions of RenderView that updates the style. * editing/FrameSelection.cpp: (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::bounds): * rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds): (WebCore::RenderView::repaintSelection): 2014-03-21 Matthew Hanson Merge r166090. 2014-03-21 Oliver Hunt Fix a crash when assigning an object to document.location https://bugs.webkit.org/show_bug.cgi?id=130213 Reviewed by Geoffrey Garen. Convert location to string before we make use the document. This prevents us from attempting to navigate a frame that has already been removed. Test: fast/dom/navigation-with-sideeffects-crash.html * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation): 2014-03-20 Matthew Hanson Merge r165821. 2014-03-18 Antti Koivisto Mutating rules returned by getMatchedCSSRules can result in crash https://bugs.webkit.org/show_bug.cgi?id=130209 Reviewed by Andreas Kling. The non-standard getMatchedCSSRules API returns CSSStyleRule objects that don't have parent stylesheet pointer (as we don't know which sheet the rule originated from). Mutating the rule via such wrapper can lead to crashes later as we fail to invalidate the underlying stylesheet. Fix by disallowing mutation of style rules that don't have parent sheet pointer. CSSStyleRule has two mutable properties selectorText and style. The latter gives back CSSStyleDeclaration. This patch disallows mutations in both cases for CSSStyleRules that don't have parent stylesheet pointer. While it is technically possible to have CSSRules that are legitimately disconnected from stylesheet (by removing rule from sheet while holding a reference to it) it never makes sense to mutate such rule as there is no way to do anything with it afterwards. Tests: fast/css/getMatchedCSSProperties-rule-mutation.html fast/css/getMatchedCSSRules-crash.html * css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText): Bail out if parent stylesheet is null. * css/PropertySetCSSStyleDeclaration.cpp: (WebCore::PropertySetCSSStyleDeclaration::setCssText): (WebCore::PropertySetCSSStyleDeclaration::setProperty): (WebCore::PropertySetCSSStyleDeclaration::removeProperty): (WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal): Allow StyleRuleCSSStyleDeclaration subclass cancel the mutation via boolean return value from willMutate. (WebCore::StyleRuleCSSStyleDeclaration::willMutate): Disallow mutation if the owning CSSStyleRule is null or has null stylesheet. (WebCore::StyleRuleCSSStyleDeclaration::didMutate): We never get here with null rule or stylesheet anymore. * css/PropertySetCSSStyleDeclaration.h: (WebCore::PropertySetCSSStyleDeclaration::willMutate): 2014-03-20 Matthew Hanson Merge r165921. 2014-03-19 Antti Koivisto Crash with long selector list https://bugs.webkit.org/show_bug.cgi?id=123006 Reviewed by Andreas Kling. Test: fast/css/long-selector-list-crash.html * css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::CSSSelectorList): (WebCore::CSSSelectorList::adoptSelectorVector): (WebCore::CSSSelectorList::operator=): * css/StyleRule.cpp: (WebCore::StyleRule::create): Add a bunch of asserts. (WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount): This could produce a zero-length selector list. 2014-03-18 Jer Noble Unreviewed Win64 build fix; explicit operators are not valid in VS2010. With the 'explicit bool' operator removed, just test weakThis.get() explicitly. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability): 2014-03-18 Jer Noble Merge r165478. 2014-03-12 Jer Noble [Mac] Crash when running media/fallback.html test in MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification() https://bugs.webkit.org/show_bug.cgi?id=130136 Reviewed by Eric Carlson. MediaPlayerPrivateAVFoundation is trying to lock its m_queueMutex from an async thread after while being destroyed in the main thread. To resolve this race condition, redispatch from the async thread to the main thread, and use a WeakPtr to determine whether the object has been destroyed or not. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability): 2014-03-18 Matthew Hanson Follow-up fix for the merge of r163579. 2014-03-17 Jeffrey Pfau Merge parts from Blink CLs 169865acce3b6bc85ac1adf07b2798aaf9aad67a and 04f613e7f0c35f444d5a9bd42da55c69df65cf64 that weren't merged to trunk Unreviewed Layout Test fix. * html/parser/HTMLConstructionSite.cpp: (WebCore::insert): (WebCore::executeInsertTask): (WebCore::executeReparentTask): (WebCore::executeInsertAlreadyParsedChildTask): 2014-03-17 Matthew Hanson Merge r165753. 2014-03-16 Brent Fulgham Provide preference to enable additional AVFoundation options https://bugs.webkit.org/show_bug.cgi?id=130275 Reviewed by Eric Carlson. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::doesHaveAttribute): Added. * html/HTMLMediaElement.h: * page/Settings.in: Add new attribute. * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::doesHaveAttribute): Added stub to call private player object's implementation of doesHaveAttribute. * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::doesHaveAttribute): * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::MediaPlayerPrivateAVFoundationCF::AVFWrapper::createAssetForURL): Check the object, and notify AVFoundationCF to use URI option if relevant. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Check the object, and notify AVFoundation to use URI option if relevant. 2014-03-17 Joseph Pecoraro Merge r165583. 2014-03-13 Joseph Pecoraro Web Inspector: Network.loadResource should include the response status code https://bugs.webkit.org/show_bug.cgi?id=130216 Reviewed by Timothy Hatcher. * inspector/InspectorResourceAgent.cpp: Record and send the http status code. * inspector/protocol/Network.json: Include status code property in the success callback. 2014-03-17 Joseph Pecoraro Merge r165582. 2014-03-13 Joseph Pecoraro Web Inspector: Network.loadResource XHR crash if page reloaded while request is ongoing https://bugs.webkit.org/show_bug.cgi?id=130211 Reviewed by Timothy Hatcher. Merged from Blink with changes, (patch by vsevik@chromium.org): http://src.chromium.org/viewvc/blink?view=revision&revision=152712 Using an XMLHttpRequest to download resources had a few issues. Being an Active DOM Object the load could be paused. Without an extra retain, when the load was cancelled (e.g. a page reload) the XHR would get destructed and could cause a crash if the list of active DOM objects was actively being iterated. Switch to a DocumentThreadableLoader to manage the load ourselves. This still uses the Memory cache, but we have a little more control. * inspector/InspectorResourceAgent.h: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::InspectorResourceAgent): (WebCore::InspectorResourceAgent::loadResource): Switch from XHR to DocumentThreadableLoader. * xml/XMLHttpRequest.h: * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::sendForInspector): Remove the now unnecessary XHR sendForInspector path. 2014-03-17 Matthew Hanson Merge r165548. 2014-03-13 Andreas Kling Don't send synchronous resize events when FrameView has auto-sizing enabled. Reviewed by Dan Bernstein. * page/FrameView.cpp: (WebCore::FrameView::sendResizeEventIfNeeded): 2014-03-17 Matthew Hanson Reverse merge r165286. 2014-03-07 Matthew Hanson Merge r165206. 2014-03-05 Jon Honeycutt Invalid cast in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients() Clang appears to be optimizing out a branch in RenderObject::node() when compiling RenderLayer::FilterInfo::updateReferenceFilterClients(). We'll work around this by factoring out the code in question into a separate member function marked NEVER_INLINE. No test possible due to . Reviewed by David Kilzer. * rendering/RenderLayerFilterInfo.cpp: (WebCore::RenderLayer::FilterInfo::layerElement): Code moved from updateReferenceFilterClients(). Returns the Element* for m_layer. (WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients): Use layerElement(). * rendering/RenderLayerFilterInfo.h: Declared layerElement(). 2014-03-12 Matthew Hanson Merge r165331. 2014-03-10 Timothy Hatcher Load source maps and their resources asynchronously. https://bugs.webkit.org/show_bug.cgi?id=112071 Reviewed by Joseph Pecoraro. * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::buildObjectForFrameTree): Honor the hiddenFromInspector flag. * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveData): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::replayXHR): (WebCore::InspectorResourceAgent::loadResource): * inspector/InspectorResourceAgent.h: Honor the hiddenFromInspector flag by keeping track of hidden identifiers in a HashSet. * inspector/protocol/Network.json: (Network.loadResource): Added. * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::hiddenFromInspector): Added. (WebCore::ResourceRequestBase::setHiddenFromInspector): Added. (WebCore::ResourceRequestBase::ResourceRequestBase): Add a flag to hide the request from the Inspector. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::sendForInspector): Added. (WebCore::XMLHttpRequest::sendForInspectorXHRReplay): Renamed. (WebCore::XMLHttpRequest::createRequest): * xml/XMLHttpRequest.h: Make Inspector loads allow cross-origins and hide their request from the Inspector itself. 2014-03-10 Brent Fulgham [Win] Build fix after r165379. * bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue): Revert to older-style C++ iteration for Windows compatibility. This can be reverted when we use VS2013 on this branch. 2014-03-07 Myles C. Maxfield Merge r162972 and r163007. 2014-03-07 Myles C. Maxfield ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint https://bugs.webkit.org/show_bug.cgi?id=114586 Reviewed by Dave Hyatt. Taken mostly from https://chromium.googlesource.com/chromium/blink/+/cb2297db16f2e9328cb4dd8b552093d6b22340a8 If RenderQuote is a subclass of RenderObject, it can't be split by the first-letter CSS pseudoclass. Instead, we should make it a subclass of RenderElement, so that it can be split properly. Test: fast/css-generated-content/quote-first-letter.html * dom/PseudoElement.cpp: (WebCore::PseudoElement::didRecalcStyle): * rendering/RenderQuote.cpp: (WebCore::RenderQuote::RenderQuote): (WebCore::RenderQuote::willBeDestroyed): (WebCore::RenderQuote::willBeRemovedFromTree): (WebCore::RenderQuote::styleDidChange): (WebCore::RenderQuote::updateText): (WebCore::RenderQuote::computeText): (WebCore::RenderQuote::updateDepth): * rendering/RenderQuote.h: * rendering/style/ContentData.cpp: (WebCore::QuoteContentData::createContentRenderer): 2014-03-10 Matthew Hanson Merge r165339. 2014-03-08 Oliver Hunt SerializedScriptValue may move Identifiers between worlds https://bugs.webkit.org/show_bug.cgi?id=129979 Reviewed by Andreas Kling. Test: fast/workers/worker-copy-shared-blob-url.html Don't use Strings to store blob URLs as String's may be Identifiers and they can only exist in one world/thread at a time. * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::put): * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::deserializeString): (WebCore::SerializedScriptValue::addBlobURL): (WebCore::SerializedScriptValue::SerializedScriptValue): * bindings/js/SerializedScriptValue.h: 2014-03-07 Matthew Hanson Merge r165138. 2014-03-05 David Kilzer Fix crash in CompositeEditCommand::cloneParagraphUnderNewElement() Reviewed by Jon Honeycutt. Merged from Blink (patch by Yuta Kitamura): https://src.chromium.org/viewvc/blink?revision=168160&view=revision http://crbug.com/345005 The root cause is CompositeEditCommand::moveParagraphWithClones() passing two positions |start| and |end| which do not follow the document order, i.e. in some situations |start| is located after |end| because of the difference in affinity. This patch fixes this crash by normalizing |end| to |start| in such situations. It also adds an ASSERT that checks the relationship between |start| and |end|. Test: editing/execCommand/format-block-crash.html * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): (WebCore::CompositeEditCommand::moveParagraphWithClones): * editing/CompositeEditCommand.h: 2014-03-07 Matthew Hanson Merge r164876. 2014-02-28 Bem Jones-Bey Properly clear m_logicallyLastRun to remove use-after-free possibility https://bugs.webkit.org/show_bug.cgi?id=129489 Reviewed by David Hyatt. A use-after-free issue was caught in Blink because m_logicallyLastRun is not cleared when the item it points to is deleted. Clearing it turns the use-after-free into a segfault, and prevents any future use-after-frees from happening. * platform/text/BidiRunList.h: (WebCore::BidiRunList::deleteRuns): 2014-03-07 Matthew Hanson Merge r165206. 2014-03-05 Jon Honeycutt Invalid cast in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients() Clang appears to be optimizing out a branch in RenderObject::node() when compiling RenderLayer::FilterInfo::updateReferenceFilterClients(). We'll work around this by factoring out the code in question into a separate member function marked NEVER_INLINE. No test possible due to . Reviewed by David Kilzer. * rendering/RenderLayerFilterInfo.cpp: (WebCore::RenderLayer::FilterInfo::layerElement): Code moved from updateReferenceFilterClients(). Returns the Element* for m_layer. (WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients): Use layerElement(). * rendering/RenderLayerFilterInfo.h: Declared layerElement(). 2014-03-06 Matthew Hanson Merge r164249. 2014-02-17 Chris Fleizach AX: Invalid cast in WebCore::AccessibilityTable::isDataTable (CRBug 280352) Merged from Blink (patch by Dominic Mazzoni): https://src.chromium.org/viewvc/blink?revision=159711&view=revision Reviewed by Oliver Hunt. Don't cast to a table cell element unless we are sure it is one. Test: accessibility/display-table-cell-causes-crash.html * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isDataTable): 2014-03-06 Matthew Hanson Merge r159489. 2013-11-19 Ryosuke Niwa Add more assertions with security implications in DocumentOrderedMap https://bugs.webkit.org/show_bug.cgi?id=124559 Reviewed by Antti Koivisto. Assert that newly added elements and existing elements in the document ordered map are in the same tree scope as the document ordered map. Also exit early if we're about to add an element in a wrong document to the map. We don't exit early in get() because the damage has already been done at that point (the element may have been deleted already). * dom/Document.cpp: (WebCore::Document::addImageElementByLowercasedUsemap): * dom/DocumentOrderedMap.cpp: (WebCore::DocumentOrderedMap::add): Assert that the newly added element is in the current tree scope. Also exit early if either the element is not in the tree scope or not in the right document. While this doesn't make the function completely fault safe, it'll catch when we try to add a detached node. (WebCore::DocumentOrderedMap::remove): Convert existing assertions to ones with security implication. (WebCore::DocumentOrderedMap::get): Assert with security implication that the element we're about to return is in the current tree scope. The element may have already been deleted if we ever hit these assertions. (WebCore::DocumentOrderedMap::getAllElementsById): Convert an existing assertion to an assertion with security implication. * dom/DocumentOrderedMap.h: * dom/TreeScope.cpp: (WebCore::TreeScope::addElementById): (WebCore::TreeScope::addElementByName): (WebCore::TreeScope::addImageMap): (WebCore::TreeScope::addLabel): * html/HTMLDocument.cpp: (WebCore::HTMLDocument::addDocumentNamedItem): (WebCore::HTMLDocument::addWindowNamedItem): * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedInto): Set InTreeScope flag before calling addImageElementByLowercasedUsemap. * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::insertedInto): Ditto for addImageMap. 2014-03-06 Matthew Hanson Merge r165145. 2014-03-05 Daniel Bates And Alexey Proskuryakov ASSERT(newestManifest) fails in WebCore::ApplicationCacheGroup::didFinishLoadingManifest() https://bugs.webkit.org/show_bug.cgi?id=129753 Reviewed by Alexey Proskuryakov. Fixes an issue where an assertion failure would occur when visiting a web site whose on-disk app cache doesn't contain a manifest resource. For some reason an app cache for a web site may be partially written to disk. In particular, the app cache may only contain a CacheGroups entry. That is, the manifest resource and origin records may not be persisted to disk. From looking over the code, we're unclear how such a situation can occur and hence have been unable to create such an app cache. We were able to reproduce this issue using an app cache database file that was provided by a person that was affected by this issue. No test included because it's not straightforward to write a test for this change. * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Assert that m_cacheBeingUpdated->manifestResource() is non-null. Currently we only document this assumption in a code comment. Also separated a single assertion expression into two assertion expressions to make it straightforward to identify the failing sub-expression on failure. * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Modified to call ApplicationCacheStorage::deleteCacheGroupRecord() to remove a cache group and associated cache records (if applicable) before inserting a cache group entry. This replacement approach will ultimately repair incomplete app cache data for people affected by this bug. (WebCore::ApplicationCacheStorage::loadCache): Log an error and return nullptr if the cache we loaded doesn't have a manifest resource. (WebCore::ApplicationCacheStorage::deleteCacheGroupRecord): Added. (WebCore::ApplicationCacheStorage::deleteCacheGroup): Extracted deletion logic for cache group record into ApplicationCacheStorage::deleteCacheGroupRecord(). * loader/appcache/ApplicationCacheStorage.h: 2014-03-06 Matthew Hanson Merge r156716. 2013-10-01 Myles C. Maxfield Center misspelling dots across width of word https://bugs.webkit.org/show_bug.cgi?id=122046 Reviewed by Darin Adler. Test: editing/spelling/spelling.html * platform/graphics/GraphicsContext.h: * platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForDocumentMarker): 2014-03-06 Matthew Hanson Merge r153788. 2013-08-07 Antti Koivisto 2.5% regression on page cycler moz https://bugs.webkit.org/show_bug.cgi?id=102822 Reviewed by Andreas Kling. DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache() triggers a style recalc for quirks mode documents in the beginning of document parsing via Document::setCompatibilityMode. This often coalesces with style recalc triggered by stylesheet loading. However on very simple documents it can generate genuinely unnecessary work. * dom/DocumentStyleSheetCollection.cpp: (WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache): Check that we actually have cached injected stylesheets before triggering style recalc. * page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): (WebCore::PageGroup::removeUserStyleSheetFromWorld): (WebCore::PageGroup::removeUserStyleSheetsFromWorld): (WebCore::PageGroup::removeAllUserContent): Fix a misspelling. (WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames): Always invalidate style when user sheets change since we don't do that in DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache anymore. * page/PageGroup.h: 2014-03-06 Matthew Hanson Merge r155071. 2013-09-04 Pratik Solanki Document::updateHoverActiveState() should allow for deferred style recalcs https://bugs.webkit.org/show_bug.cgi?id=120700 Reviewed by Simon Fraser. Add an extra argument to Document::updateHoverActiveState() to specify if a style recalc should be done. The default value keeps the current behavior of doing a style recalc. iOS touch handling code will pass in DeferRecalcStyleIfNeeded to avoid the work. No new tests because no functional changes. * dom/Document.cpp: (WebCore::Document::updateHoverActiveState): * dom/Document.h: 2014-03-05 Matthew Hanson Merge r158802. 2013-11-06 Ryosuke Niwa Crash in SliderThumbElement::dragFrom https://bugs.webkit.org/show_bug.cgi?id=123873 Reviewed by Sam Weinig. Moved Ref. * html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::dragFrom): 2014-03-05 Matthew Hanson Merge r158724. 2013-11-05 Ryosuke Niwa Use-after-free in SliderThumbElement::dragFrom https://bugs.webkit.org/show_bug.cgi?id=123873 Reviewed by Andreas Kling. Ref the SliderThumbElement since it could go away inside dragFrom. Test: fast/forms/range/range-type-change-onchange-2.html * html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): 2014-03-05 Matthew Hanson Merge r163599. 2014-02-06 Jeffrey Pfau loadSubframe can return null in SubframeLoader::loadOrRedirectSubframe https://bugs.webkit.org/show_bug.cgi?id=128344 Reviewed by Ryosuke Niwa. * loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe): 2014-03-05 Matthew Hanson Merge r164170. 2014-02-15 Renata Hodovan ASSERT_WITH_SECURITY_IMPLICATION in WebCore::toElement https://bugs.webkit.org/show_bug.cgi?id=128810 Reviewed by Ryosuke Niwa. Make CompositeEditCommand::cloneParagraphUnderNewElement() to work when |outerNode| doesn't contain |start|. Before this patch, CompositeEditCommand::cloneParagraphUnderNewElement() tried to copy ancestry nodes from |start| to Document node when |start| position isn't in |outerNode|. This patch changes CompositeEditCommand::cloneParagraphUnderNewElement() to copy |start| to |outerNode| only if |outerNode| contains |start| position. Merged from Blink https://src.chromium.org/viewvc/blink?revision=161762&view=revision by yosin@chromium.org. Test: editing/execCommand/indent-with-uneditable-crash.html * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): 2014-03-05 Matthew Hanson Merge r160065. 2013-12-03 Ryosuke Niwa Potential crash in RenderView::selectionBounds and RenderView::repaintSelection https://bugs.webkit.org/show_bug.cgi?id=125207 Reviewed by Simon Fraser. Merge https://chromium.googlesource.com/chromium/blink/+/f9e6e288a5aa959f05c374806121aaf0fc52d440 Update style in FrameSelection instead of RenderView's member functions. These are the last two member functions of RenderView that updates the style. * editing/FrameSelection.cpp: (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::bounds): * rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds): (WebCore::RenderView::repaintSelection): 2014-03-05 Matthew Hanson Merge r164367. 2014-02-19 Daniel Bates Do not dispatch change event twice in single step action https://bugs.webkit.org/show_bug.cgi?id=116936 Reviewed by Ryosuke Niwa. Merged from Blink (patch by Kent Tamura): https://src.chromium.org/viewvc/blink?view=rev&revision=151175 Test: fast/forms/number/number-type-update-by-change-event.html * html/InputType.cpp: (WebCore::InputType::stepUpFromRenderer): 2014-03-05 Matthew Hanson Merge r164204. 2014-02-16 Andreas Kling Ensure that removing an iframe from the DOM tree disconnects its Frame. Merged from Blink (patch by Adam Klein): https://src.chromium.org/viewvc/blink?revision=156174&view=revision SubframeLoadingDisabler wasn't catching the case when an